Tickets :: [#4268] set queue

6.0.0-RC7

6/29/26

History
Attachments
Comment
Watch
Download

Summary	set queue
Queue	Whups
Type	Enhancement
State	Resolved
Priority	1. Low
Owners
Requester	tmerritt (at) email (dot) arizona (dot) edu
Created	8/8/06 (7265 days ago)
Due
Updated	8/10/06 (7263 days ago)
Assigned
Resolved	8/10/06 (7263 days ago)
Milestone
Patch	Yes

295	Chuck Hagenbuch	Comment #6 State ⇒ Resolved	Reply to this comment
Looks good, it's committed. Thanks very much for the patch and for sticking with my somewhat scattered review.

201	tmerritt (at) email (dot) arizona (dot) edu	Comment #5 New Attachment: queue_move.patch	Reply to this comment
Attached is a new patch which adds a permission check for the destination queue

549	Chuck Hagenbuch	Deleted Original Message

459	Chuck Hagenbuch	Deleted Original Message

329	Chuck Hagenbuch	Comment #4 New Attachment: whups_queue_move.patch	Reply to this comment
I'm attaching an updated patch because I removed a debug line and made one other minor change (don't need Auth::getAuth() as well since we're checking queue permissions). But in looking at this I realized it doesn't enforce any permissions on the queue you're moving the ticket _to_. You need to add a permissions check on the $whups->getQueues() call in SetQueueStep1Form.

581	tmerritt (at) email (dot) arizona (dot) edu	Comment #3 New Attachment: qmove.patch	Reply to this comment
Attched is a new patch which adds the functionality to Whups::getTicketTabs as well. Thanks

349	Chuck Hagenbuch	Comment #2 State ⇒ Feedback	Reply to this comment
You'd need to update Whups::getTicketTabs as well.

137	tmerritt (at) email (dot) arizona (dot) edu	Comment #1 Priority ⇒ 1. Low Type ⇒ Enhancement Summary ⇒ set queue Queue ⇒ Whups New Attachment: queue_move.patch State ⇒ New	Reply to this comment
Currently, moving a ticket between queues requires one to be a whups administrator. The following patch lightens this restriction by requiring that a person only have PERMS_DELETE on the queue that they are moving the ticket from, allowing for finer grained access for queue administrators.