I just committed a fix for _connect() to solve the foreach() warning.   
Looks OK here on both PHP4 and PHP5 systems.

Warning: Invalid argument supplied for foreach() in 
/etc/httpd/htdocs/horde/imp/acl.php on line 141

Warning: Invalid argument supplied for foreach() in 
/etc/httpd/htdocs/horde/imp/acl.php on line 180

Try what I just committed to HEAD and 3.1.2.

Instead of checking for the PHP version, you should check if 
imap_getacl() exists, this is semantically more correct. Also, all 
imap_* calls (beside the imap_error* calls) need to be silenced. And 
you shouldn't use $_connected, but instead check in _connect() whether 
the connection has already been made.

Beside that, looks good.

How's this look?

I vote for Chuck's suggestion.

Aside from not being comprehensive, what's wrong with the php 5 
solution? Could even combine it with the sleep(), only sleeping for 
php 4. Not pretty, but at least it's compartmentalized.

We're using Cyrus 2.3 with Murder.  What seems to be happening is that 
SETACL and GETACL are run on different Cyrus front-end servers.  The 
ACL information hasn't propogated to all servers by the time GETACL is 
run so the data is stale.  Options include:



1) Add a sleep() before the GETACL (or after the SETACL) to allow time 
for propogation to occur.

2) Store the ACL information on the client and use that instead of 
asking the server again.

3) Use PHP5's imap_getacl() if available since it will use the same 
stream (aka same server) as the SETACL.



None of these seem correct.

Works perfectly for me here with Cyrus 2.2.12 and PLAIN authentication.

After some investigation Matt Selsky and I have obtained some more 
information.



First of all, we're running Cyrus IMAP with RFC 2086 ACL support.



It seems that the query made in the connection created in Horde's 
_getACL() in rfc2086.php is not obtaining the correct information 
after the imap_setacl() function is invoked earlier in the page load.



Upon submitting a new acl, imap_setacl is called with the new 
information. For testing purposes, I inserted an imap_getacl (> PHP 5) 
call immediately after this and the returned array contains the 
correct information.



Later in invocation, _getACL executes a standard IMAP GETACL query, 
but the server response does not contain the newly created ACL, 
meaning the array returned by _getACL is incorrect.



Attached is a screenshot that shows this information.

After submitting a new ACL, the tool confirms the ACL was created but 
does not show the ACL in the list. See attached screenshot.