Once again I'm befuddled, this time by how my previous fix had any 
effect at all. NOW it's actually fixed.

yes, that's exactly as it appears on my copies.



Don't know how accurate the js errors are, but it said line 328 which 
is 2 above the links[i] = null; line.

And you're _positive_ that the for loop in the resume: function looks 
like this?



         for (var i = links.length - 1; i >= 0; --i) {

             
this.reviewDiv.insertBefore(document.createTextNode(links[i].innerHTML), 
links[i]);

             this.reviewDiv.removeChild(links[i]);

             links[i] = null;

         }



The "links[i] = null;" line is the critical one, that's what fixed the 
problem for me.

ok, here's what I get:



[Exception... "Node was not found" code: "8" nresult: "0x80530008

(NS_ERROR_DOM_NOT_FOUND_ERR)" location:

"http://192.168.0.250/horde/dimp/js/SpellChecker.js Line: 328"]

If you still have problems, please apply this patch to js/src/SpellChecker.js:



Index: SpellChecker.js

===================================================================

RCS file: /repository/dimp/js/src/SpellChecker.js,v

retrieving revision 1.6

diff -u -r1.6 SpellChecker.js

--- SpellChecker.js     20 Apr 2006 04:38:45 -0000      1.6

+++ SpellChecker.js     20 Apr 2006 18:07:31 -0000

@@ -309,6 +309,7 @@

       */

      resume: function()

      {

+try {

          if (this.choicesDiv) {

              this.choicesDiv.parentNode.removeChild(this.choicesDiv);

              this.choicesDiv = null;

@@ -342,6 +343,7 @@

          if (this.onAfterSpellCheck) {

              this.onAfterSpellCheck();

          }

+} catch (e) { alert(e); }

      },



      /**



then copy js/src/SpellChecker.js to js/SpellChecker.js. Reload, and 
when you click resume you should get an alert with the exception 
causing failure in it.

Yes, cleared the cache, restarted windows, disabled PHP acceleration 
and restarted the server. Also tried a machine & browser that had 
never seen Dimp before.



I'm doing another cvs update just in case, but for some reason it's 
going really slow here at the moment.

Are you _sure_ that you cleared your cache in FF and got the latest JS code?

A recent CVS update partially fixed the problem whereby clicking 
"Resume Editing" would have no effect. For me the problem is fixed in 
IE but persists in Firefox (v1.5.0.2)