Tickets :: [#3556] [PATCH] custom folder icons don't work

6.0.0-beta1

9/20/25

Summary	[PATCH] custom folder icons don't work
Queue	IMP
Queue Version	HEAD
Type	Bug
State	Resolved
Priority	1. Low
Owners	jan (at) horde (dot) org, slusarz (at) horde (dot) org
Requester	tokoe (at) kde (dot) org
Created	03/02/2006 (7142 days ago)
Due
Updated	03/06/2006 (7138 days ago)
Assigned	03/06/2006 (7138 days ago)
Resolved	03/06/2006 (7138 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	No

03/06/2006 04:35:36 PM	Jan Schneider	Comment #9 State ⇒ Resolved	Reply to this comment
No, I am confused. I have looked at least 3 times at that file and didn't see it. I guess I need some vacation. Sorry for the trouble.

03/06/2006 04:21:17 PM	Michael Slusarz	Comment #8	Reply to this comment
Maybe I am confused, but what about this example in hooks.php.dist? // Note that in IMP 4.2.x, the expected return value from this hook has // changed. See the below examples for more information. ... // // Use this example for IMP 4.2.x+. // // $newmailboxes[$box] = array( // // 'icon' => 'kronolith.png', // // 'icondir' => $GLOBALS['registry']->getImageDir('kronolith') // // 'alt' => _("Calendar") // // );

03/06/2006 03:45:55 PM	Jan Schneider	Comment #7	Reply to this comment
I know. I was talking about hooks.php.dist in HEAD.

03/06/2006 03:35:57 PM	Michael Slusarz	Comment #6	Reply to this comment
No, the examples in hooks.php.dist still use the old syntax (from FW3). And this is intended. The new custom folder code is only in IMP 4.2 and, IMHO, it would cause all sorts of confusion to put in examples in Horde 3.1's hooks.php for a version of IMP that doesn't even exist yet. It is abundantly clear in IMP 4.2's documentation that the format of the icons hook has changed, and it explains where the user needs to go (a version of Horde 3.2+) to see the changed format.

03/06/2006 09:09:03 AM	Jan Schneider	Comment #5 State ⇒ Assigned	Reply to this comment
No, the examples in hooks.php.dist still use the old syntax (from FW3).

03/05/2006 10:02:34 PM	Michael Slusarz	Comment #4 State ⇒ Resolved	Reply to this comment
That patch is (almost) correct, the variable name had changed indeed. But the examples in hooks.php.dist still use the old syntax, it would be great if you could provide a patch that fixes these. This has already been documented in the hooks.php file (in HEAD at least), and in imp/docs/UPGRADING.

03/03/2006 09:27:58 AM	Jan Schneider	Comment #3	Reply to this comment
That patch is (almost) correct, the variable name had changed indeed. But the examples in hooks.php.dist still use the old syntax, it would be great if you could provide a patch that fixes these.

03/02/2006 05:33:48 PM	Chuck Hagenbuch	Comment #2 Assigned to Jan Schneider Assigned to Michael Slusarz State ⇒ Feedback	Reply to this comment
I know this has changed recently, so I'm leery of changing Tree.php instead of adjusting the hook. Jan or Michael, can you comment here?

03/02/2006 03:51:10 PM	tokoe (at) kde (dot) org	Comment #1 Priority ⇒ 1. Low Type ⇒ Bug Summary ⇒ [PATCH] custom folder icons don't work Queue ⇒ IMP New Attachment: imp_custom_icons.patch State ⇒ Unconfirmed	Reply to this comment
Hi, in current IMP version custom folder icons from the _imp_hook_mbox_icons don't work because the parameter of Tree::getCustomIcon() seems to be changed. The attached patch should fix this issue. Ciao, Tobias