Tickets :: [#3533] link attachments - email missing domain information

6.0.0-beta1

9/24/25

Summary	link attachments - email missing domain information
Queue	IMP
Queue Version	HEAD
Type	Bug
State	Resolved
Priority	2. Medium
Owners
Requester	eric.rostetter (at) physics (dot) utexas (dot) edu
Created	02/25/2006 (7151 days ago)
Due
Updated	02/16/2007 (6795 days ago)
Assigned
Resolved	02/16/2007 (6795 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	No

02/16/2007 08:05:23 PM	Michael Slusarz	Comment #4 State ⇒ Resolved	Reply to this comment
Jan fixed this already: http://cvs.horde.org/diff.php?r1=2.5.10.11&r2=2.5.10.12&f=imp%2Fattachment.php

03/08/2006 06:55:24 AM	Michael Slusarz	Version ⇒ HEAD

03/08/2006 06:55:02 AM	Michael Slusarz	Comment #3	Reply to this comment
This is a VFS issue, not an IMP issue. I will move this to another bug report. See ~~Bug 3573~~ for this issue.

03/08/2006 06:53:01 AM	Michael Slusarz	Comment #2 State ⇒ Summary ⇒ link attachments - email missing domain information	Reply to this comment
[Show Quoted Text - 11 lines][Hide Quoted Text] First, the attachment is correctly in <tempdir>/.horde/imp/compose/ when composing. But when the message is sent, the code is supposed to move/rename it to <tempdir>/.horde/imp/attachments/<user>/<timestamp> but this only works if <tempdir>/.horde/imp/attachments/<user> already exists. If not, it silently fails without any notice/error/etc. I've "fixed" this in my version with a homemade patch where I do a recursive mkdir() on the path before trying to vfs->rename() the file to it in imp/lib/Compose.php. I can supply my local patch if requested. This is a VFS issue, not an IMP issue. I will move this to another bug report. Second, if notification is enabled for the links, such that you are e-mailed when the link is viewed, it is sending to the username only (since my users login with the username only) and not the full username+domain. This is the sole focus of this ticket now.

02/25/2006 05:10:25 AM	Eric Rostetter	Comment #1 Priority ⇒ 2. Medium Type ⇒ Bug Summary ⇒ two problems with link attachments Queue ⇒ IMP State ⇒ Unconfirmed	Reply to this comment
Running current CVS FRAMEWORK_3 code of Horde/IMP/etc, when trying to compose messages with attachments and have the attachments sent as links, I have the following two problems. Note: running PHP 4.3.2 which may or may not be relevent, and using the "file" VFS for composing with attachments, and for storing the attachments for the links. First, the attachment is correctly in <tempdir>/.horde/imp/compose/ when composing. But when the message is sent, the code is supposed to move/rename it to <tempdir>/.horde/imp/attachments/<user>/<timestamp> but this only works if <tempdir>/.horde/imp/attachments/<user> already exists. If not, it silently fails without any notice/error/etc. I've "fixed" this in my version with a homemade patch where I do a recursive mkdir() on the path before trying to vfs->rename() the file to it in imp/lib/Compose.php. I can supply my local patch if requested. Second, if notification is enabled for the links, such that you are e-mailed when the link is viewed, it is sending to the username only (since my users login with the username only) and not the full username+domain. Since my webmail is behind a load-balancing front-end with no hostname, this ends up trying to send to user@172.16.78.23 instead of to user@mydomain. I've locally patched this to just append the domain name in imp/attachments.php, which obviously isn't right. I'm thinking the best way to "fix" this might be to provide a hook for use in attachments.php for how to modify the user? No patch for this one... This probably is an edge case for people like me (login without realm/domain, web server has a private IP and no DNS for it, sendmail on web server isn't configured to correctly convert IP to something else _yet_ but will be soon, etc).