Summary | messages not marked as 'personal' |
Queue | IMP |
Queue Version | 4.0.3 |
Type | Bug |
State | Not A Bug |
Priority | 2. Medium |
Owners | |
Requester | dgehl (at) inverse (dot) ca |
Created | 10/27/2005 (7212 days ago) |
Due | |
Updated | 10/28/2005 (7211 days ago) |
Assigned | |
Resolved | 10/28/2005 (7211 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | No |
State ⇒ Not A Bug
hasAddress() *already* require bare e-mail addresses according to
their documentation and, sure enough, both message.php and mailbox.php
do all the pre-processing needed to remove all of the personal
information from an e-mail string.
State ⇒ Unconfirmed
Priority ⇒ 2. Medium
Type ⇒ Bug
Summary ⇒ messages not marked as 'personal'
Queue ⇒ IMP
username <user@example.com>
instead of simply
user@example.com
no messages are marked any more as 'personal' in mailbox.php and
message.php.
This problem could be solved by changing in imp/lib/Identity/imp.php the
getMatchingIdentity and hasAddress functions.
in getMatchingIdentity, instead of
/* Next, search all from addresses. */
if (isset($own_addresses[$find_address])) {
return $own_addresses[$find_address];
}
we could use
foreach (array_keys($own_addresses) as $current_address) {
if (IMP::bareAddress($current_address) == $find_address)
{
return true;
}
}
and in hasAddress($address), instead of
// return isset($list[$address]);
we could use
foreach (array_keys($list) as $current_address) {
if (IMP::bareAddress($current_address) == $address) {
return true;
}
}
return false;
I observed this in IMP 4.0.3, but after a look in the cvs, I have the
impression that it should also apply to all later versions (including
cvs).