Tickets :: [#2285] No confirmation for SPAM report in message view

6.0.0-beta1

7/28/25

Summary	No confirmation for SPAM report in message view
Queue	IMP
Queue Version	HEAD
Type	Enhancement
State	Resolved
Priority	1. Low
Owners	Horde Developers (at) , selsky (at) columbia (dot) edu
Requester	kevin_myer (at) iu13 (dot) org
Created	07/18/2005 (7315 days ago)
Due
Updated	09/26/2005 (7245 days ago)
Assigned	09/24/2005 (7247 days ago)
Resolved	09/26/2005 (7245 days ago)
Milestone
Patch	No

09/26/2005 09:44:12 AM	Matt Selsky	State ⇒ Resolved

09/26/2005 09:43:40 AM	Matt Selsky	Comment #11	Reply to this comment
Committed to 4.0.4

09/26/2005 09:21:38 AM	Matt Selsky	Comment #10	Reply to this comment
I removed the PHP checks from imp/templates/message/javascript.inc and imp/templates/mailbox/javascript.inc. imp/mailbox.php and imp/message.php don't need to check that reporting is enabled since that is handled in IMP_Spam::reportSpam().

09/26/2005 08:59:55 AM	Jan Schneider	Comment #9	Reply to this comment
Do imp/mailbox.php and imp/message.php need to check that spam reporting is enabled before they process the report? To be on the safe side, I would say yes.

09/26/2005 08:51:01 AM	Matt Selsky	Comment #8	Reply to this comment
Do imp/mailbox.php and imp/message.php need to check that spam reporting is enabled before they process the report?

09/26/2005 08:43:21 AM	Matt Selsky	Comment #7 Assigned to Matt Selsky	Reply to this comment
Committed to HEAD, thanks!

09/26/2005 08:31:52 AM	Jan Schneider	Comment #6	Reply to this comment
I think the PHP checks in the javascript code are not necessary. Submit() isn't called with the spam arguments anyway if the spam links are not enabled.

09/26/2005 08:24:47 AM	Matt Selsky	Comment #5 New Attachment: message-spam-confirm-v3.patch	Reply to this comment
Restore BC in widget() calls and disable access key checks.

09/26/2005 07:40:30 AM	Matt Selsky	Comment #4 New Attachment: message-spam-confirm-v2.patch	Reply to this comment
Remove extra args to Horde::widget() and don't use $spam_link, $notspam_link variables.

09/24/2005 04:32:14 PM	Jan Schneider	State ⇒ Assigned Assigned to Horde Developers

09/24/2005 12:27:17 PM	kevin_myer (at) iu13 (dot) org	Comment #3 New Attachment: message-spam-confirm.patch	Reply to this comment
This patch just mimics the code in the mailbox view now, for spam reporting. Hopefully, if its right, it can make it into IMP 4.0.4.

08/12/2005 03:00:08 PM	Jan Schneider	Type ⇒ Enhancement State ⇒ Accepted Priority ⇒ 1. Low

07/18/2005 08:01:31 AM	Jan Schneider	Comment #2 State ⇒ Feedback	Reply to this comment
I think the rationale behind that was that people are actually seeing the message they are going to mark as spam, so they shouldn't mark a message unintended. But I agree that hitting the link by accident is still possible, so a patch to change this would be fine.

07/18/2005 12:33:43 AM	kevin_myer (at) iu13 (dot) org	Comment #1 Priority ⇒ 1. Low Type ⇒ Bug Summary ⇒ No confirmation for SPAM report in message view Queue ⇒ IMP State ⇒ Unconfirmed	Reply to this comment
When you are in the folder/mailbox view (index of messages - whatever its called) and you select a message to Report as Spam, you are prompted with a confirmation dialog box, prior to being able to submit the message as spam. However, when you are actually reading a message and choose the Report as Spam link, the message is submitted (and deleted, if so configured) automatically, with no confirmation. This is causing problems for people who accidentally hit that link when reading a message.