Tickets :: [#2265] Add better shared resource support to menus

6.0.0-beta1

9/19/25

Summary	Add better shared resource support to menus
Queue	Horde Base
Queue Version	HEAD
Type	Enhancement
State	Rejected
Priority	1. Low
Owners
Requester	csacca (at) thecsl (dot) org
Created	07/13/2005 (7373 days ago)
Due
Updated	04/18/2006 (7094 days ago)
Assigned
Resolved	04/18/2006 (7094 days ago)
Milestone
Patch	No

04/18/2006 10:05:29 AM	Jan Schneider	State ⇒ Rejected

03/28/2006 01:54:59 PM	Jan Schneider	Comment #19 State ⇒ Feedback	Reply to this comment
Are you going to update the patch?

10/24/2005 02:15:35 PM	Jan Schneider	Comment #18	Reply to this comment
One thing left: the patch loosed the current option highlighting in the menu's drop down list, i.e. it shows +/- again where we displayed the options in different colors instead.

10/24/2005 02:03:54 PM	Jan Schneider	Deleted Original Message

08/17/2005 05:08:24 PM	csacca (at) thecsl (dot) org	Comment #17 New Attachment: kron_and_nag_menu_v5[1].patch	Reply to this comment
Erg, I found stupid mistake in my patch. I forgot to add in 'global $browser;' to the functions so they puked. I've added the line to each function and now they work correctly. -Chris

08/10/2005 12:02:58 PM	Jan Schneider	Version ⇒ HEAD State ⇒ Accepted

08/10/2005 12:01:58 PM	Jan Schneider	Deleted Original Message

08/10/2005 12:01:49 PM	Jan Schneider	Deleted Original Message

08/10/2005 12:01:41 PM	Jan Schneider	Deleted Original Message

08/09/2005 03:46:02 PM	csacca (at) thecsl (dot) org	Comment #16 New Attachment: kron_and_nag_menu_v5.patch	Reply to this comment
Double-quotes are slower since the intepreter needs to check the strings to variable interpolation. Makes sense... You need to update your patch to use double-quotes for gettext strings otherwise the strings won't get added to the list of things to translate. Done

08/09/2005 02:27:21 AM	Matt Selsky	Comment #15	Reply to this comment
6. Don't use double-quoted strings unless necessary for variable interpolation or newlines, etc. I did this, but I was just kinda wondering why not use double-qoutes? Double-quotes are slower since the intepreter needs to check the strings to variable interpolation. You need to update your patch to use double-quotes for gettext strings otherwise the strings won't get added to the list of things to translate.

08/08/2005 04:25:16 PM	csacca (at) thecsl (dot) org	Comment #14 New Attachment: kron_and_nag_menu_v4.patch	Reply to this comment
Ok, finished all that... I think. : P 5. Please don't combine patches to different applications in one file unless you do the diff from the Horde directory. Try using cvs diff -uRn. -uRn didn't work for me, but I did make a patch that from the horde directory should work with patch -p0 6. Don't use double-quoted strings unless necessary for variable interpolation or newlines, etc. I did this, but I was just kinda wondering why not use double-qoutes? Thanks for all the quick feedback. Chris Sacca

08/07/2005 03:54:52 AM	Chuck Hagenbuch	Comment #13	Reply to this comment
Done and done, though I'm still not that sure that it's perfect. Getting better. :) 1. Please rename the functions to getTasklistWidget()/getCalendarWidget(). Personal taste, but a bit clearer about what the function is. 2. For xhtml, you should use disabled="disabled", not disabled="true". 3. Please spell out boolean and integer in phpdoc comments. 4. You need to echo the result of the function in the templates you use it in; you just call it, which results in nothing being output. 5. Please don't combine patches to different applications in one file unless you do the diff from the Horde directory. Try using cvs diff -uRn. 6. Don't use double-quoted strings unless necessary for variable interpolation or newlines, etc. 7. In several places in Nag, the old code would pre-select the default tasklist (possibly in Kronolith as well). Your function doesn't provide an option for that; it should be added back in. Not trying to be picky for no reason, but since you've been improving it, I thought I'd give you as much feedback as I could. :)

08/04/2005 06:20:51 PM	csacca (at) thecsl (dot) org	Comment #12 New Attachment: kron_and_nag_menu_v3.patch	Reply to this comment
This patch needs to be against HEAD since it's new code; it doesn't apply cleanly at all. Also, in Kronolith, you've lost the <optgroup> functionality - please restore that. It should be carried over to Nag, even. Done and done, though I'm still not that sure that it's perfect. Sorry, I'm really not that familiar with the code base yet. Thanks for helping me out, Chris Sacca

08/03/2005 10:10:41 PM	Chuck Hagenbuch	Comment #11	Reply to this comment
This patch needs to be against HEAD since it's new code; it doesn't apply cleanly at all. Also, in Kronolith, you've lost the <optgroup> functionality - please restore that. It should be carried over to Nag, even.

08/03/2005 08:54:59 PM	Chuck Hagenbuch	Deleted Original Message

08/03/2005 08:54:47 PM	Chuck Hagenbuch	Deleted Original Message

08/03/2005 08:54:38 PM	Chuck Hagenbuch	Deleted Original Message

08/02/2005 04:10:54 PM	csacca (at) thecsl (dot) org	Comment #10 New Attachment: kron_and_nag_menu_v2.patch	Reply to this comment
That doesn't work. You show read-only shares in the import and edit screens, you allow to select no share at all (by adding the My Calendar etc. entries), and you didn't use gettext for the strings. ok, I think I've made a patch that covers everything. I takes care of showing different permissions, uses gettext, and uses the disabled attr in <select> to disallow selecting the non-share entries. Thoughts? Chris Sacca

07/28/2005 01:36:38 PM	csacca (at) thecsl (dot) org	Comment #9	Reply to this comment
That doesn't work. You show read-only shares in the import and edit screens, you allow to select no share at all (by adding the My Calendar etc. entries), and you didn't use gettext for the strings. Thanks for the feedback. I'll take another shot at this and attempt to correct my mistakes.

07/28/2005 01:20:47 PM	Jan Schneider	Comment #8	Reply to this comment
That doesn't work. You show read-only shares in the import and edit screens, you allow to select no share at all (by adding the My Calendar etc. entries), and you didn't use gettext for the strings.

07/26/2005 02:56:36 PM	csacca (at) thecsl (dot) org	Comment #7 New Attachment: kron_and_nag_menu.patch	Reply to this comment
Ok, that makes a lot of sense. Where should I put the function? Somewhere in horde/templates/ ? Or maybe in framwork/Menu/ ? The most sensible place would be in Share.php, but that breaks backwards compatibility, so I'd go with one function per application, in lib/App.php. It took me a little while, but I put something together. Might apply a little fuzzy, but I works under my installation. Thanks, Chris

07/18/2005 03:16:22 PM	Chuck Hagenbuch	Comment #6	Reply to this comment
Ok, that makes a lot of sense. Where should I put the function? Somewhere in horde/templates/ ? Or maybe in framwork/Menu/ ? The most sensible place would be in Share.php, but that breaks backwards compatibility, so I'd go with one function per application, in lib/App.php.

07/18/2005 03:14:53 PM	csacca (at) thecsl (dot) org	Comment #5	Reply to this comment
Now that this work is being done in so many places, you should move it to a function so it's not duplicated everywhere. Ok, that makes a lot of sense. Where should I put the function? Somewhere in horde/templates/ ? Or maybe in framwork/Menu/ ?

07/18/2005 12:41:10 AM	Chuck Hagenbuch	Comment #4 State ⇒ Feedback	Reply to this comment
Now that this work is being done in so many places, you should move it to a function so it's not duplicated everywhere.

07/13/2005 03:24:59 PM	csacca (at) thecsl (dot) org	Comment #3 New Attachment: cvs_nag_sharing_menu.patch	Reply to this comment
Nag Patch

07/13/2005 03:24:20 PM	csacca (at) thecsl (dot) org	Comment #2 New Attachment: cvs_kron_sharing_menu.patch	Reply to this comment
Kronolith Patch

07/13/2005 03:23:32 PM	csacca (at) thecsl (dot) org	Comment #1 Priority ⇒ 1. Low State ⇒ New Queue ⇒ Horde Base Type ⇒ Enhancement Summary ⇒ Add better shared resource support to menus	Reply to this comment
I think it would be good if the behavior of the calendar selection menu in menu.inc of kronolith was expanded into the create/edit/import calendar selection menus as well. In addition I would find the bracketed owner name useful in nag, and possibly other services that use shared resources. I wrote a couple patches (against HEAD) to deal with this in nag and kronolith. Although they don't really address the issues talked about in ~~bug #362~~, I believe they still might be useful.