Tickets :: [#2181] < and > in diff.php

6.0.0-beta1

9/24/25

Summary	< and > in diff.php
Queue	Horde Framework Packages
Type	Bug
State	Resolved
Priority	1. Low
Owners	Horde Developers (at)
Requester	martin (at) mein-horde (dot) de
Created	06/24/2005 (7397 days ago)
Due
Updated	06/29/2005 (7392 days ago)
Assigned	06/26/2005 (7395 days ago)
Resolved	06/29/2005 (7392 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	No

06/29/2005 12:24:39 AM	Chuck Hagenbuch	Comment #5 State ⇒ Resolved	Reply to this comment
That didn't handle all cases. I've fixed it in CVS now, though.

06/26/2005 06:35:58 AM	martin (at) mein-horde (dot) de	Comment #4 New Attachment: inline.php.patch	Reply to this comment
Ok, try this one. it's against framework/Text_Diff/Diff/Renderer/inline.php

06/26/2005 04:57:15 AM	Chuck Hagenbuch	Comment #3 Version ⇒ Queue ⇒ Horde Framework Packages State ⇒ Feedback	Reply to this comment
The problem is in the Text_Diff inline renderer, not in Wicked. Your patch will badly mangle diff emails. The inline renderer has to do the htmlspecialchars, since it is responsible for adding HTML tags into the string.

06/25/2005 09:44:52 AM	Jan Schneider	State ⇒ Assigned Assigned to Horde Developers

06/24/2005 09:41:34 PM	martin (at) mein-horde (dot) de	Comment #2 New Attachment: StandardPages.php.patch	Reply to this comment
Ok, this patch against wicked/lib/Page/StandardPage.php fixes the problem. But I'm not entirely sure if it's the right place to use htmlspecialchars....but it works :-)

06/24/2005 07:20:12 PM	martin (at) mein-horde (dot) de	Comment #1 Priority ⇒ 1. Low Type ⇒ Bug Summary ⇒ < and > in diff.php Queue ⇒ Wicked State ⇒ Unconfirmed	Reply to this comment
< and > are not displayed as < and > on diff.php. See http://ferris.dyndns.info/~blackm/horde/wicked/display.php?page=WikiHome and the history http://ferris.dyndns.info/~blackm/horde/wicked/diff.php?page=WikiHome&v2=&v1=1.3