6.0.0-alpha12
6/8/25

[#2114] convert_imp_filters.php doesn't convert correctly
Summary convert_imp_filters.php doesn't convert correctly
Queue Ingo
Queue Version 1.0.1
Type Bug
State Resolved
Priority 1. Low
Owners
Requester joonas.hamalainen (at) nettitieto (dot) fi
Created 06/09/2005 (7304 days ago)
Due
Updated 06/13/2005 (7300 days ago)
Assigned 06/09/2005 (7304 days ago)
Resolved 06/13/2005 (7300 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
06/13/2005 09:21:46 AM Jan Schneider Comment #5
State ⇒ Resolved
Reply to this comment
Nice catch, committed, thanks.
06/10/2005 06:44:06 PM robin (dot) west (at) dal (dot) ca Comment #4 Reply to this comment
Hi - I just ran into this bug myself with convert_imp_filters.php. The 
problem is this line (I think):



$filters = $ingo_storage->retrieve(INGO_STORAGE_ACTION_FILTERS)



There is an optional boolean parameter for the retrieve() function 
which prevents it from retrieving cached data for the session. I 
switched it on thusly:



$filters = $ingo_storage->retrieve(INGO_STORAGE_ACTION_FILTERS, false)



... and the problem went away. Don't know if this is the correct 
solution but it seems to work.



-Robin


06/09/2005 01:17:52 PM joonas (dot) hamalainen (at) nettitieto (dot) fi Comment #3
New Attachment: horde_prefs.sql Download
Reply to this comment
Alright, here is true data, just anonymized.



I tried with this myself too, and it gives faulty result.



There is twice same data, with only different usernames. I would think 
that 4 first entries are enough to see what is happening, but those 4 
more gives stronger effect.



If there is need, I can provide more data, but I think this gives idea.
06/09/2005 12:40:44 PM Jan Schneider Comment #2
State ⇒ Feedback
Reply to this comment
Can you upload any example SQL dump as short as possible to reproduce this?
06/09/2005 12:23:03 PM joonas (dot) hamalainen (at) nettitieto (dot) fi Comment #1
State ⇒ Unconfirmed
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ convert_imp_filters.php doesn't convert correctly
Queue ⇒ Ingo
Reply to this comment
I have ran into troubles with convert_imp_filters.php. Tried upgrading 
our old system to new, settings are these:



Old system:

Horde 2.2.3

IMP 3.2.1



My new setup is this:

Horde 3.0.4

Imp 4.0.3

Ingo 1.0.1



Took dump from old system db and tried converting from that. Script 
gives correct output, showing everything as expected and results are 
correct. However when looking what it has actually done is quite 
disaster.



Script seems to add every rule it encounters into same queue, and 
assings current queue to user currently being prosessed.



That means first user gets his filters converted correctly, and then 
things break down: second user gets 1.st user filters and own, 3rd 
user gets 1st and 2nd and own filters and so forth until everyone have 
been prosessed.



This quite much kills easy possibilities to upgrade setup, at least 
when sieve has been used. No knowledge if it works with other.

Saved Queries