Committed.

Much better, go ahead.

How's this?

Please put the gettext strings in double quotes, and make only the 
varying error messages translateable.

This needs more testing, but I think we're on the right track.

Committed, thanks.

Here's the Mail_sendmail patch...

I think the ideal solution would be to modify the PEAR::raiseError() 
call in Mail_sendmail to include the error code as a seperate 
parameter as well (it's in the raiseError() definition). Then in IMP, 
if there's an error code set, you can introduce the translatable 
strings. We shouldn't rely on the Mail_sendmail string staying the 
same, but the error code should be reliable.



Only downside is it requires changes to both packages, but it degrades 
to the current behavior just fine either way.

Is it safe to rely on Mail_sendmail to never change the strings it 
returns?  If it is, I can move this code to imp/lib/Compose.php and 
only attempt to parse the error message if $conf['mailer']['type'] == 
'sendmail'.

If we do it in IMP we could use gettext and translate the strings.

This patch lets the PEAR module Mail_sendmail know about the sendmail 
error codes and what they mean.  Or should the logic be more inside of 
IMP?

Bounty added: http://www.horde.org/bounties/details.php#imp_sendmailcodes

New features go to HEAD only.

Patch?

Even worse, in the case of EX_NOUSER, the user is given the impression 
that the mail was sent to NONE of the intended recipients.  However, 
if the mail was addressed to multiple recipients, it has been 
successfully sent to the extant recipients.  This easily leads to 
users clicking "send" multiple times to try to clear the error, 
sending multiple copies to the recipients that DO exist.



Handling in this case, with multiple recipients and one or more 
unknown to local sendmail, is very poor.  IMP should fail to send the 
message completely AND report the unknown addresses (reported by 
sendmail on stderr).

When using sendmail locally to inject e-mail, return codes from 
sendmail are displayed very cryptically.  IE: "There was an error 
sending your message: sendmail returned error code 67"  Sendmail only 
returns 6-7 error codes, shown in sendmail(8), and defined in 
/usr/include/sysexits.h.  Readable messages for these would be useful. 
  For instance, 67 is EX_NOUSER, which means one of the addressees 
didn't exist.  The user sending mail would much rather see that than 
"error 67"



Thanks...