6.0.0-alpha12
6/12/25

[#9972] Link attachment couldn't be downloaded
Summary Link attachment couldn't be downloaded
Queue IMP
Queue Version 5.0.1
Type Bug
State Resolved
Priority 1. Low
Owners slusarz (at) horde (dot) org
Requester alberto (at) pesadilla (dot) org
Created 04/25/2011 (5162 days ago)
Due
Updated 04/25/2011 (5162 days ago)
Assigned
Resolved 04/25/2011 (5162 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
04/25/2011 07:22:00 PM Michael Slusarz Assigned to Michael Slusarz
State ⇒ Resolved
 
04/25/2011 07:21:37 PM Git Commit Comment #2 Reply to this comment
Changes have been made in Git for this ticket:

Bug #9972: Fix viewing linked attachments

  4 files changed, 12 insertions(+), 5 deletions(-)
http://git.horde.org/horde-git/-/commit/a874ce8a6ee5dfe27dd871fbea5508a0ff9d7c9b
04/25/2011 03:18:40 PM alberto (at) pesadilla (dot) org Comment #1
Priority ⇒ 1. Low
Patch ⇒ No
Milestone ⇒
Queue ⇒ IMP
Summary ⇒ Link attachment couldn't be downloaded
Type ⇒ Bug
State ⇒ Unconfirmed
Reply to this comment
Hello,

There is a problem with H4 and linked attachment.

This is not fixed en GIT version:
http://git.horde.org/co.php/imp/attachment.php?rt=horde-git&ws=1&r=8cc572d2fc648758a682d4a19742c50bcb36e62e

The link sent is http://address/imp/attachment.php?u=mail&t=timestamp&f=file

(i can confirm it with imp/lib/Compose.php file: 
http://git.horde.org/co.php/imp/lib/Compose.php?rt=horde-git&ws=1&r=22d8cbacb6182e2c36745e794696340337e2d93f lines 
2449->2463)

and the expected is user_name=mail&time_stamp=timestamp&filename=file




Solution could be:

imp/attachment.php (add lines between line 30 and line 31)
$vars->mail_user = $vars->u;
$vars->time_stamp = $vars->t;
$vars->file_name = $vars->f;

also there is a bug in line 31:
if (!$vars->mail_user || !$vars->$time_stamp || !$vars->file_name) {

$vars->time_stamp instead of $vars->$time_stamp




Furthermore, there is a problem sending a mail when attachment is downloaded

Solution could be:

imp/attachment.php
Change line 107: $msg->send($mail_address, $msg_headers);
with line: $msg->send($mail_address, $msg_headers, 
$GLOBALS['injector']->getInstance('IMP_Mail'));



Saved Queries