Tickets :: [#9845] Error displayed and logged whenever a message is deleted or restored

6.0.0-beta1

7/18/25

Summary	Error displayed and logged whenever a message is deleted or restored
Queue	IMP
Queue Version	5.0
Type	Bug
State	Resolved
Priority	3. High
Owners	slusarz (at) horde (dot) org
Requester	jcblanco (at) fi (dot) upm (dot) es
Created	04/08/2011 (5215 days ago)
Due
Updated	04/08/2011 (5215 days ago)
Assigned	04/08/2011 (5215 days ago)
Resolved	04/08/2011 (5215 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	Yes

04/08/2011 07:26:37 PM	Michael Slusarz	Comment #7	Reply to this comment
Re-reading RFC 4551, looks like Timo is correct. modsequences always need to be sent in SELECT/EXAMINE responses if the CONDSTORE extension is available.

04/08/2011 07:22:10 PM	Michael Slusarz	Comment #6 State ⇒ Resolved	Reply to this comment
There is a LOG I don't know if it has all you need but I've done the same steps that produce the error. This was fine. Sure enough, the server is returning HIGHESTMODSEQ information even though we are not requesting it. I'll ask Timo if this is appropriate. The change made in this ticket fixes this issue.

04/08/2011 07:11:38 PM	jcblanco (at) fi (dot) upm (dot) es	Comment #5 New Attachment: imap.log.txt	Reply to this comment
[Show Quoted Text - 17 lines][Hide Quoted Text] It sort of sounds like your IMAP server is broken. The only way this could happen is if your server sent MODSEQ information even if no CONDSTORE enabling command has been sent. Well is a typical dovecot 1.2.9 installation, and i'm not the only one giving this error, if you see the distribution list there is another person with the same problem. I will commit the patch since it doesn't add much overhead and will cover the situation I describe above. For my personal information, could you provide an IMAP log of a mailbox SELECT/EXAMINE so I can verify this? Details on how to get IMAP debug log is below I'll try but I've never done so. There is a LOG I don't know if it has all you need but I've done the same steps that produce the error. Regards [Show Quoted Text - 15 lines][Hide Quoted Text] ----- To further debug this issue, we need details of the IMP -> IMAP/POP communication. To enable debugging, see instructions contained in imp/config/backends.php (the 'debug' config parameter). Debugging should not be enabled on a production server, Attach/post only the portion of the log that directly deals with the problem reported (it may be simplest to clear the log file and then perform the event that causes the error).

04/08/2011 06:59:23 PM	jcblanco (at) fi (dot) upm (dot) es	Comment #4	Reply to this comment
It sort of sounds like your IMAP server is broken. The only way this could happen is if your server sent MODSEQ information even if no CONDSTORE enabling command has been sent. Well is a typical dovecot 1.2.9 installation, and i'm not the only one giving this error, if you see the distribution list there is another person with the same problem. I will commit the patch since it doesn't add much overhead and will cover the situation I describe above. For my personal information, could you provide an IMAP log of a mailbox SELECT/EXAMINE so I can verify this? Details on how to get IMAP debug log is below I'll try but I've never done so. [Show Quoted Text - 13 lines][Hide Quoted Text] ----- To further debug this issue, we need details of the IMP -> IMAP/POP communication. To enable debugging, see instructions contained in imp/config/backends.php (the 'debug' config parameter). Debugging should not be enabled on a production server, Attach/post only the portion of the log that directly deals with the problem reported (it may be simplest to clear the log file and then perform the event that causes the error).

04/08/2011 05:15:12 PM	Git Commit	Comment #3	Reply to this comment
Changes have been made in Git for this ticket: ~~Bug #9845~~: Fix for IMAP servers that report MODSEQ information even though CONDSTORE has not been enabled 2 files changed, 7 insertions(+), 4 deletions(-) http://git.horde.org/horde-git/-/commit/bbb5e8ffd3c3058d0e02ff481959e246f3b79821

04/08/2011 05:15:02 PM	Michael Slusarz	Comment #2 State ⇒ Feedback Assigned to Michael Slusarz	Reply to this comment
It sort of sounds like your IMAP server is broken. The only way this could happen is if your server sent MODSEQ information even if no CONDSTORE enabling command has been sent. I will commit the patch since it doesn't add much overhead and will cover the situation I describe above. For my personal information, could you provide an IMAP log of a mailbox SELECT/EXAMINE so I can verify this? Details on how to get IMAP debug log is below ----- To further debug this issue, we need details of the IMP -> IMAP/POP communication. To enable debugging, see instructions contained in imp/config/backends.php (the 'debug' config parameter). Debugging should not be enabled on a production server, Attach/post only the portion of the log that directly deals with the problem reported (it may be simplest to clear the log file and then perform the event that causes the error).

04/08/2011 02:26:02 PM	jcblanco (at) fi (dot) upm (dot) es	Comment #1 Milestone ⇒ State ⇒ Unconfirmed New Attachment: Horde_Imap_Client_Socket.php.patch.txt Patch ⇒ Yes Queue ⇒ IMP Due ⇒ 04/08/2011 Summary ⇒ Error displayed and logged whenever a message is deleted or restored Type ⇒ Bug Priority ⇒ 3. High	Reply to this comment
in IMP traditional and dynamic Modes, whenever a message is deleted or restore we see an error message in the web page and also is logged, the error los is like: [Thu Apr 07 22:38:38 2011] [error] [client XXX.XXX.XXX.XXX] PHP Fatal error: Call to a member function get() on a non-object in /usr/share/php5/PEAR/Horde/Imap/Client/Socket.php on line 2931, referer: http://XXX.fi.upm.es/horde/imp/ I've found that in version RC2 the code in the line 2931 was conditioned by a previous if in line 2921 of the RC version that checks for "condstore", in the FINAL version this check was removed. If we apply the attached patch the error goes away but I don't know if this patch my cause some other error or missing code