Tickets :: [#9792] fix module logic in horde-translation script

6.0.0-beta1

11/8/25

Summary	fix module logic in horde-translation script
Queue	Horde Base
Queue Version	Git master
Type	Bug
State	Resolved
Priority	1. Low
Owners	jan (at) horde (dot) org
Requester	vilius (at) lnk (dot) lt
Created	04/03/2011 (5333 days ago)
Due
Updated	04/03/2011 (5333 days ago)
Assigned
Resolved	04/03/2011 (5333 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	Yes

04/03/2011 10:06:57 PM	Jan Schneider	Comment #4 Assigned to Jan Schneider State ⇒ Resolved	Reply to this comment
There is an even more elegant solution that doesn't initialize File_Find with each method call.

04/03/2011 10:06:27 PM	Git Commit	Comment #3	Reply to this comment
Changes have been made in Git for this ticket: Don't initialize File_Find before searching for libraries (~~Bug #9792~~). 1 files changed, 1 insertions(+), 1 deletions(-) http://git.horde.org/horde-git/-/commit/b8e4b8962b69b4dcb3601fd68de186e7257a8b83

04/03/2011 08:42:10 PM	vilius (at) lnk (dot) lt	Comment #2 New Attachment: translation[1].patch	Reply to this comment
On the other hand, there is more elegant solution :)

04/03/2011 08:05:19 PM	vilius (at) lnk (dot) lt	Comment #1 Priority ⇒ 1. Low New Attachment: translation.patch Patch ⇒ Yes Milestone ⇒ Queue ⇒ Horde Base Summary ⇒ fix module logic in horde-translation script Type ⇒ Bug State ⇒ Unconfirmed	Reply to this comment
Horde_Translation_Script constructor is trying to load File_Find, but the check for installed module was done later. So user saw no indication of what's wrong. Patch fixes this.