6.0.0-alpha12
6/12/25

[#9769] Another JS error during mailbox loading
Summary Another JS error during mailbox loading
Queue IMP
Queue Version Git master
Type Bug
State Resolved
Priority 1. Low
Owners slusarz (at) horde (dot) org
Requester jan (at) horde (dot) org
Created 04/01/2011 (5186 days ago)
Due
Updated 04/06/2011 (5181 days ago)
Assigned
Resolved 04/06/2011 (5181 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
04/06/2011 07:56:59 AM Michael Slusarz State ⇒ Resolved
 
04/06/2011 07:51:16 AM Git Commit Comment #5 Reply to this comment
Changes have been made in Git for this ticket:

Bug #9769: Make sure thread value is always an object

  1 files changed, 1 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/c6d446a0999440b566fc7d4f6ef443d4b6b4d430
04/05/2011 11:13:54 PM Jan Schneider Comment #4 Reply to this comment
Would you be happening to use Cyrus also, with CONDSTORE enabled but 
MODSEQs disabled (e.g. Bug #9796)?  Because this simply should not 
happen:
No, at least I don't find any occurence of either of those in the imap log.
04/05/2011 11:06:43 PM Michael Slusarz Comment #3 Reply to this comment
Would you be happening to use Cyrus also, with CONDSTORE enabled but 
MODSEQs disabled (e.g. Bug #9796)?  Because this simply should not 
happen:

"cacheid":"V1233013246|U75950|M-57|9|0"

That is saying that the status return for the mailbox is reporting -57 
messages.  I can't even begin to reproduce this.

That being said, the error reported is because the thread data was 
returned as an empty array which was converted by json_encode into an 
array.  However, viewport is expecting this to be a hash.  Thus, the 
solution is to always cast the thread return as a a hash.

I'll postpone committing this until the releases are finished.
04/01/2011 10:07:22 AM Jan Schneider Comment #2 Reply to this comment
And for completeness, the deleteMessages request and response right before:


view:INBOX.Mailinglisten.MythTV
cacheid:V1233013246|U75950|M83|9|0
slice:18:109
cache:{26}INBOX.Mailinglisten.MythTV75867:75949
uid:{26}INBOX.Mailinglisten.MythTV75867:75936


/*-secure-{"response":{"deleted":{"mbox":"INBOX.Mailinglisten.MythTV","uids":"{26}INBOX.Mailinglisten.MythTV75867:75936","remove":1},"ViewPort":{"cacheid":"V1233013246|U75950|M-57|9|0","data":[],"metadata":{"readonly":0,"unseen":0,"thread":[]},"rowlist":[],"totalrows":13,"view":"INBOX.Mailinglisten.MythTV","update":1,"disappear":[75867,75868,75869,75870,75871,75872,75873,75874,75875,75876,75877,75878,75879,75880,75881,75882,75883,75884,75885,75886,75887,75888,75889,75890,75891,75892,75893,75894,75895,75896,75897,75898,75899,75900,75901,75902,75903,75904,75905,75906,75907,75908,75909,75910,75911,75912,75913,75914,75915,75916,75917,75918,75919,75920,75921,75922,75923,75924,75925,75926,75927,75928,75929,75930,75931,75932,75933,75934,75935,75936,75937,75938,75939,75940,75941,75942,75943,75944,75945,75946,75947,75948,75949]}}}*/
04/01/2011 10:05:44 AM Jan Schneider Comment #1
Priority ⇒ 1. Low
Patch ⇒ No
Milestone ⇒
Assigned to Michael Slusarz
Summary ⇒ Another JS error during mailbox loading
Type ⇒ Bug
State ⇒ Assigned
Queue ⇒ IMP
Reply to this comment
onException #<Hash:{'message': 'Object  has no method \'update\'', 
'stack': 'TypeError: Object  has no method \'update\'\n    at 
klass.<anonymous> 
(http://neo.wg.de/headhorde/imp/js/viewport.js:1516:54)\n    at 
http://neo.wg.de/headhorde/js/prototype.js:825:18\n    at klass._each 
(http://neo.wg.de/headhorde/js/prototype.js:1237:7)\n    at klass.each 
(http://neo.wg.de/headhorde/js/prototype.js:824:12)\n    at 
klass.update (http://neo.wg.de/headhorde/imp/js/viewport.js:1508:20)\n 
    at klass._ajaxResponse 
(http://neo.wg.de/headhorde/imp/js/viewport.js:863:16)\n    at 
klass.parseJSONResponse 
(http://neo.wg.de/headhorde/imp/js/viewport.js:844:18)\n    at 
Object.onDoActionComplete 
(http://neo.wg.de/headhorde/imp/js/dimpbase.js:3481:27)\n    at 
Object.doActionComplete 
(http://neo.wg.de/headhorde/imp/js/dimpcore.js:210:18)\n    at 
http://neo.wg.de/headhorde/imp/js/dimpbase.js:547:26', 'type': 
'undefined_method', 'arguments': ['update', []], 'name': 'TypeError'}>

This should have been the response that caused the error:

/*-secure-{"response":{"ViewPort":{"cacheid":"V1233013246|U75950|M13|9|0","data":{"75937":{"imapuid":75937,"view":"INBOX.Mailinglisten.MythTV","flag":["\\answered","\\seen","attach"],"draft":1,"size":"10 KB","date":"16.03.2011","from":"Martin Andersen","subject":"[mythtv-users] Performance issue on 0.24-fixes - Playback stalls when a recording starts\/ends","listmsg":1},"75938":{"imapuid":75938,"view":"INBOX.Mailinglisten.MythTV","flag":["\\seen","attach"],"draft":1,"size":"24 KB","date":"21.03.2011","from":"An: mythtv-users@mythtv.org","subject":"Re: [mythtv-users] Performance issue on 0.24-fixes - Playback stalls when a recording starts\/ends","listmsg":1},"75940":{"imapuid":75940,"view":"INBOX.Mailinglisten.MythTV","flag":["\\seen"],"draft":1,"size":"6 KB","date":"21.03.2011","from":"Paul Gardiner","subject":"Re: [mythtv-users] Performance issue on 0.24-fixes - Playback stalls when a recording starts\/ends","listmsg":1},"75939":{"imapuid":75939,"view":"INBOX.Mailinglisten.MythTV","flag":["\\seen"],"draft":1,"size":"5 KB","date":"21.03.2011","from":"Duncan Brown","subject":"Re: [mythtv-users] Performance issue on 0.24-fixes - Playback stalls when a recording starts\/ends","listmsg":1},"75941":{"imapuid":75941,"view":"INBOX.Mailinglisten.MythTV","flag":["\\seen"],"draft":1,"size":"8 KB","date":"22.03.2011","from":"Johnny Walker","subject":"Re: [mythtv-users] Performance issue on 0.24-fixes - Playback stalls when a recording starts\/ends","listmsg":1},"75944":{"imapuid":75944,"view":"INBOX.Mailinglisten.MythTV","flag":["\\seen"],"draft":1,"size":"6 KB","date":"22.03.2011","from":"Martin Andersen","subject":"Re: [mythtv-users] Performance issue on 0.24-fixes - Playback stalls when a recording starts\/ends","listmsg":1},"75945":{"imapuid":75945,"view":"INBOX.Mailinglisten.MythTV","flag":["\\seen","attach"],"draft":1,"size":"7 KB","date":"22.03.2011","from":"Brian J. Murrell","subject":"Re: [mythtv-users] Performance issue on 0.24-fixes - Playback stalls when a recording starts\/ends","listmsg":1},"75947":{"imapuid":75947,"view":"INBOX.Mailinglisten.MythTV","flag":["\\seen","attach"],"draft":1,"size":"11 KB","date":"29.03.2011","from":"Kenneth Emerson","subject":"Re: [mythtv-users] Playback problem -- random short pauses","listmsg":1},"75948":{"imapuid":75948,"view":"INBOX.Mailinglisten.MythTV","flag":["\\seen"],"draft":1,"size":"5 KB","date":"29.03.2011","from":"Jean-Yves Avenard","subject":"Re: [mythtv-users] Playback problem -- random short pauses","listmsg":1},"75949":{"imapuid":75949,"view":"INBOX.Mailinglisten.MythTV","flag":["\\seen"],"draft":1,"size":"5 KB","date":"29.03.2011","from":"Kenni Lund","subject":"Re: [mythtv-users] Playback problem -- random short pauses","listmsg":1},"75946":{"imapuid":75946,"view":"INBOX.Mailinglisten.MythTV","flag":["\\seen"],"draft":1,"size":"5 KB","date":"30.03.2011","from":"Jean-Yves Avenard","subject":"Re: [mythtv-users] Playback problem -- random short pauses","listmsg":1},"75943":{"imapuid":75943,"view":"INBOX.Mailinglisten.MythTV","flag":["\\seen"],"draft":1,"size":"7 KB","date":"30.03.2011","from":"Michael Drons","subject":"Re: [mythtv-users] Playback problem -- random short pauses","listmsg":1},"75942":{"imapuid":75942,"view":"INBOX.Mailinglisten.MythTV","flag":["\\seen"],"draft":1,"size":"5 KB","date":"30.03.2011","from":"Josu Lazkano","subject":"Re: [mythtv-users] Playback problem -- random short 
pauses","listmsg":1}},"metadata":{"readonly":0,"unseen":0,"thread":{"75937":"","75938":"2","75940":"14","75939":"2","75941":"4","75944":"04","75945":"004","75947":"","75948":"4","75949":"04","75946":"004","75943":"0004","75942":"00004"}},"rowlist":{"75937":1,"75938":2,"75940":3,"75939":4,"75941":5,"75944":6,"75945":7,"75947":8,"75948":9,"75949":10,"75946":11,"75943":12,"75942":13},"totalrows":13,"view":"INBOX.Mailinglisten.MythTV","requestid":617,"update":1}}}*/

That was the viewPort request:

view:INBOX.Mailinglisten.MythTV
cacheid:V1233013246|U75950|M-57|9|0
requestid:617
slice:1:93

Saved Queries