6.0.0-alpha14
7/2/25

[#9737] Accesskeys broken in Chrome/Mac
Summary Accesskeys broken in Chrome/Mac
Queue Horde Base
Queue Version Git master
Type Bug
State Resolved
Priority 2. Medium
Owners Horde Developers (at) , chuck (at) horde (dot) org, jan (at) horde (dot) org
Requester chuck (at) horde (dot) org
Created 03/29/2011 (5209 days ago)
Due
Updated 04/05/2011 (5202 days ago)
Assigned
Resolved 04/05/2011 (5202 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
04/05/2011 03:10:01 PM Chuck Hagenbuch Comment #9
Assigned to Chuck Hagenbuch
State ⇒ Resolved
Reply to this comment
That commit fixes things for me... let's reopen if other problems show up.
04/05/2011 03:09:24 PM Git Commit Comment #8 Reply to this comment
Changes have been made in Git for this ticket:

Bug #9737: Fix accesskeys in Chrome/Mac on elements that are links

  1 files changed, 1 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/0e7341cc7adbdf9d293f5e4735beed4c6874eaf5
03/30/2011 08:25:53 AM Jan Schneider Comment #7 Reply to this comment
On Linux and Windows, Chrome is triggering the default action of A 
tags when you fire an event manually. If you have an event handler 
registered on that element, the action is triggered twice, so you end 
up with two popups.
This is of course broken behavior and has security implications 
because it's an open field for click-hijacking.
03/30/2011 05:02:10 AM Chuck Hagenbuch Comment #6
Priority ⇒ 2. Medium
Reply to this comment
This is the block that's triggering on Chrome 10/Mac causing the cases 
not to finish (if I comment out the return everything seems to work 
fine):

                 if (navigator.userAgent.indexOf('Chrome/') > -1 &&
                     elt.tagName == 'A') {
                     return;
                 }

What is that preventing in the versions you have?
03/29/2011 02:13:50 PM Jan Schneider Priority ⇒ 1. Low
 
03/29/2011 02:13:41 PM Jan Schneider Comment #5
Assigned to Horde DevelopersHorde Developers
Reply to this comment
They work fine in Chrome 8 on Linux and Chrome 10 on Windows. I don't 
have a Mac version that is supported by Chrome, so someone else need 
to take a look at those cases.
03/29/2011 01:37:42 PM Chuck Hagenbuch Comment #4 Reply to this comment
Your commit fixed things in DIMP, at least the common ones I use. On 
the test page, F, G, H, I, J, K, L, M all fail.
03/29/2011 10:57:00 AM Git Commit Comment #3 Reply to this comment
Changes have been made in Git for this ticket:

Fix access keys with Chrome on elements that are not links. Maybe 
fixes bug #9737?

  2 files changed, 9 insertions(+), 5 deletions(-)
http://git.horde.org/horde-git/-/commit/503221deb7286cf43637bd79e24845e7af38f20d
03/29/2011 09:04:09 AM Jan Schneider Comment #2 Reply to this comment
Please open /horde/js/accesskeys.html and test which cases don't work.
03/29/2011 04:03:55 AM Chuck Hagenbuch Comment #1
State ⇒ Assigned
Patch ⇒ No
Milestone ⇒
Assigned to Jan Schneider
Queue ⇒ Horde Base
Summary ⇒ Accesskeys broken in Chrome/Mac
Type ⇒ Bug
Priority ⇒ 2. Medium
Reply to this comment
No accesskeys are working for me in DIMP; in Nag, they just focus the 
menu item, instead of activating it. No JS errors that I see. Cleared 
all cached static js files, etc.

Saved Queries