6.0.0-beta1
7/5/25

[#9641] Fall through case structure breaks sync
Summary Fall through case structure breaks sync
Queue Turba
Queue Version 3.0-ALPHA1
Type Bug
State Resolved
Priority 2. Medium
Owners jan (at) horde (dot) org
Requester d-fens (at) 00010111 (dot) de
Created 03/09/2011 (5232 days ago)
Due
Updated 03/09/2011 (5232 days ago)
Assigned
Resolved 03/09/2011 (5232 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch Yes

History
03/09/2011 03:04:18 PM Jan Schneider Assigned to Jan Schneider
State ⇒ Resolved
Version ⇒ 3.0-ALPHA1
 
03/09/2011 03:04:02 PM Jan Schneider Version ⇒
Queue ⇒ Turba
 
03/09/2011 03:02:19 PM Git Commit Comment #2 Reply to this comment
Changes have been made in Git for this ticket:

Fix importing contacts with SyncML (Simon Bühler, Bug #9641).

  2 files changed, 2 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/c5e8e3597e54fb380dbde163d2642877c2297811
03/09/2011 01:03:18 PM d-fens (at) 00010111 (dot) de Comment #1
Priority ⇒ 2. Medium
Patch ⇒ Yes
Milestone ⇒
Queue ⇒ Synchronization
Summary ⇒ Fall through case structure breaks sync
Type ⇒ Bug
State ⇒ Unconfirmed
Reply to this comment
hi,

syncing fails when the break is missing

commit 6ae99a4cad81ff9341fe43d8fa2e630db31effc6
Author: Simon Bühler <simon@aktionspotenzial.de> 2011-03-09 13:58:33
Committer: Simon Bühler <simon@aktionspotenzial.de> 2011-03-09 13:58:33
Parent: 4672b21f76501934e1006a415fbf3362762d6c05 (Simple H4-ifying, 
largely untested.)
Branches: master

fix case statement

Signed-off-by: Simon Bühler <simon@aktionspotenzial.de>
------------------------------ turba/lib/Api.php 
------------------------------
diff --git a/turba/lib/Api.php b/turba/lib/Api.php
index 63ac571..e500fd2 100644
--- a/turba/lib/Api.php
+++ b/turba/lib/Api.php
@@ -687,6 +687,7 @@

                      return $ids;
                  }
+                break;

              case 'activesync':
                  $content = $driver->fromASContact($content);

Saved Queries