Tickets :: [#9612] Onclick handler for Horde_Tree broken

6.0.0-alpha12

6/12/25

Summary	Onclick handler for Horde_Tree broken
Queue	Horde Base
Queue Version	Git master
Type	Bug
State	Resolved
Priority	2. Medium
Owners	slusarz (at) horde (dot) org
Requester	mrubinsk (at) horde (dot) org
Created	03/01/2011 (5217 days ago)
Due
Updated	03/04/2011 (5214 days ago)
Assigned
Resolved	03/04/2011 (5214 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	No

03/04/2011 06:21:45 PM	Michael Slusarz	State ⇒ Resolved

03/04/2011 06:21:39 PM	Git Commit	Comment #3	Reply to this comment
Changes have been made in Git for this ticket: ~~Request #9612~~: Do not allow setting onclick in Horde_Tree 4 files changed, 13 insertions(+), 21 deletions(-) http://git.horde.org/horde-git/-/commit/d4da93521a36744dbb1b5f54486cc0a39edd8f1d

03/01/2011 06:26:01 PM	Michael Slusarz	Comment #2	Reply to this comment
The onclick element should be completely removed. Going forward, we should not be running any javascript via HTML on* parameters. The one place where using embedded javascript may be acceptable is to open a popup window. But this should be done via the url parameter rather than onclick anyway.

03/01/2011 05:23:14 PM	Michael Rubinsky	Comment #1 Priority ⇒ 2. Medium Patch ⇒ No Milestone ⇒ Assigned to Michael Slusarz Queue ⇒ Horde Base Summary ⇒ Onclick handler for Horde_Tree broken Type ⇒ Bug State ⇒ Assigned	Reply to this comment
The commit 6f15654d breaks running arbitrary javascript when clicking on a node of the tree. The code that outputes the onclick attribute is now commented out, and a generic click handler is used in it's place. I'm guessing these changes were never finished? E.g., See Hermes' Start Stopwatch link in the Horde sidebar. It looks like a generic click handler is attached, but the actual javascript passed in to use is ignored.