6.0.0-beta6
4/10/26

[#9575] Horde_Block rewrite
Summary Horde_Block rewrite
Queue Horde Framework Packages
Queue Version Git master
Type Bug
State Resolved
Priority 3. High
Owners slusarz (at) horde (dot) org
Requester slusarz (at) horde (dot) org
Created 2/11/11 (5537 days ago)
Due
Updated 3/18/11 (5502 days ago)
Assigned
Resolved 3/18/11 (5502 days ago)
Github Issue Link
Github Pull Request
Milestone 4
Patch No

History
03/18/2011 03:54:55 PM Michael Slusarz Comment #13
State ⇒ Resolved
Reply to this comment
This should be done now.
03/18/2011 07:50:16 AM Git Commit Comment #12 Reply to this comment
Changes have been made in Git for this ticket:

Bug #9575: Move portal rendering out of IMP

  16 files changed, 111 insertions(+), 343 deletions(-)
http://git.horde.org/horde-git/-/commit/986a805ec583825aac75094ce167e3c364a83c83
03/03/2011 11:00:43 PM Git Commit Comment #11 Reply to this comment
Changes have been made in Git for this ticket:

Revert "Bug #9575: Temporary fix to load existing portals again."
This reverts commit 16d05e3a8c745eaa8551d7783e5619c29a086c63.

This completely breaks loading newly added blocks.  Old blocks
will either need to be converted or deleted/re-added.

http://git.horde.org/horde-git/-/commit/c0e3e263d650cbdec3dbadaba8206dc446e229df
02/22/2011 09:48:10 PM Chuck Hagenbuch Comment #10 Reply to this comment
My opinion is we should have dynamic portal code in Horde, re-usable 
for specific application portals the same way the current static 
portal code is...
02/22/2011 01:41:54 AM iron_hat (at) hotmail (dot) com Comment #9 Reply to this comment
$injector->getInstance('Horde_Core_Factory_BlockCollection')->create() 
is returning a list with lowercase application names, thus the results 
do not match up with the Block class names. This is a problem when 
adding blocks to the horde portal.

02/21/2011 08:24:20 AM Michael Slusarz Comment #8
Taken from Horde DevelopersHorde Developers
Reply to this comment
The only task remaining should be moving the dynamic portal code from 
IMP -> Horde.

Or do we just want to re-use the current portal code (and associated 
management screen)view in an IFRAME?
02/14/2011 08:16:06 PM Git Commit Comment #7 Reply to this comment
Changes have been made in Git for this ticket:

Bug #9575: This package no longer exists

http://git.horde.org/horde-git/-/commit/b44214c3d5c16f2960cd192c4aa4635b8018e84f
02/14/2011 07:58:51 PM Git Commit Comment #6 Reply to this comment
Changes have been made in Git for this ticket:

Bug #9575: Add upgrade code for H3 -> H4 portal preferences format

  create mode 100644 ansel/lib/LoginTasks/SystemTask/UpgradeFromAnsel1.php
  create mode 100644 framework/Core/lib/Horde/Core/Block/Upgrade.php
http://git.horde.org/horde-git/-/commit/d358f42baa3feebe55b74dd56aaef53035283721
02/14/2011 07:58:44 PM Git Commit Comment #5 Reply to this comment
Changes have been made in Git for this ticket:

Bug #9575: Horde_Core_Block improvements.
Make base class abstract.
Cleaner way of ensuring that we are in app scope when loading driver.
phpdoc

http://git.horde.org/horde-git/-/commit/ea5e06bcca21fea0c34d214c331e229221030abd
02/14/2011 07:58:38 PM Git Commit Comment #4 Reply to this comment
Changes have been made in Git for this ticket:

Bug #9575: Merge horde/Block into horde/Core.

  delete mode 100644 framework/Block/lib/Horde/Block.php
  delete mode 100644 framework/Block/lib/Horde/Block/Exception.php
  delete mode 100644 framework/Block/lib/Horde/Block/Layout.php
  delete mode 100644 framework/Block/lib/Horde/Block/Layout/Manager.php
  delete mode 100644 framework/Block/lib/Horde/Block/Layout/View.php
  delete mode 100644 framework/Block/lib/Horde/Block/Translation.php
  delete mode 100644 framework/Block/lib/Horde/Block/Ui.php
  delete mode 100644 framework/Block/locale/Horde_Block.pot
  delete mode 100644 framework/Block/locale/ar/LC_MESSAGES/Horde_Block.po
  delete mode 100644 framework/Block/locale/bg/LC_MESSAGES/Horde_Block.po
  delete mode 100644 framework/Block/locale/bs/LC_MESSAGES/Horde_Block.po
  delete mode 100644 framework/Block/locale/ca/LC_MESSAGES/Horde_Block.po
  delete mode 100644 framework/Block/locale/cs/LC_MESSAGES/Horde_Block.mo
  delete mode 100644 framework/Block/locale/cs/LC_MESSAGES/Horde_Block.po
  delete mode 100644 framework/Block/locale/da/LC_MESSAGES/Horde_Block.mo
  delete mode 100644 framework/Block/locale/da/LC_MESSAGES/Horde_Block.po
  delete mode 100644 framework/Block/locale/de/LC_MESSAGES/Horde_Block.mo
  delete mode 100644 framework/Block/locale/de/LC_MESSAGES/Horde_Block.po
  delete mode 100644 framework/Block/locale/el/LC_MESSAGES/Horde_Block.mo
  delete mode 100644 framework/Block/locale/el/LC_MESSAGES/Horde_Block.po
  delete mode 100644 framework/Block/locale/en/LC_MESSAGES/Horde_Block.mo
  delete mode 100644 framework/Block/locale/en/LC_MESSAGES/Horde_Block.po
  delete mode 100644 framework/Block/locale/es/LC_MESSAGES/Horde_Block.mo
  delete mode 100644 framework/Block/locale/es/LC_MESSAGES/Horde_Block.po
  delete mode 100644 framework/Block/locale/et/LC_MESSAGES/Horde_Block.mo
  delete mode 100644 framework/Block/locale/et/LC_MESSAGES/Horde_Block.po
  delete mode 100644 framework/Block/locale/eu/LC_MESSAGES/Horde_Block.po
  delete mode 100644 framework/Block/locale/fa/LC_MESSAGES/Horde_Block.po
  delete mode 100644 framework/Block/locale/fi/LC_MESSAGES/Horde_Block.mo
  delete mode 100644 framework/Block/locale/fi/LC_MESSAGES/Horde_Block.po
  delete mode 100644 framework/Block/locale/fr/LC_MESSAGES/Horde_Block.mo
  delete mode 100644 framework/Block/locale/fr/LC_MESSAGES/Horde_Block.po
  delete mode 100644 framework/Block/locale/gl/LC_MESSAGES/Horde_Block.po
  delete mode 100644 framework/Block/locale/he/LC_MESSAGES/Horde_Block.mo
  delete mode 100644 framework/Block/locale/he/LC_MESSAGES/Horde_Block.po
  delete mode 100644 framework/Block/locale/hr/LC_MESSAGES/Horde_Block.mo
  delete mode 100644 framework/Block/locale/hr/LC_MESSAGES/Horde_Block.po
  delete mode 100644 framework/Block/locale/hu/LC_MESSAGES/Horde_Block.mo
  delete mode 100644 framework/Block/locale/hu/LC_MESSAGES/Horde_Block.po
  delete mode 100644 framework/Block/locale/id/LC_MESSAGES/Horde_Block.po
  delete mode 100644 framework/Block/locale/is/LC_MESSAGES/Horde_Block.po
  delete mode 100644 framework/Block/locale/it/LC_MESSAGES/Horde_Block.mo
  delete mode 100644 framework/Block/locale/it/LC_MESSAGES/Horde_Block.po
  delete mode 100644 framework/Block/locale/ja/LC_MESSAGES/Horde_Block.mo
  delete mode 100644 framework/Block/locale/ja/LC_MESSAGES/Horde_Block.po
  delete mode 100644 framework/Block/locale/km/LC_MESSAGES/Horde_Block.po
  delete mode 100644 framework/Block/locale/ko/LC_MESSAGES/Horde_Block.mo
  delete mode 100644 framework/Block/locale/ko/LC_MESSAGES/Horde_Block.po
  delete mode 100644 framework/Block/locale/lt/LC_MESSAGES/Horde_Block.mo
  delete mode 100644 framework/Block/locale/lt/LC_MESSAGES/Horde_Block.po
  delete mode 100644 framework/Block/locale/lv/LC_MESSAGES/Horde_Block.mo
  delete mode 100644 framework/Block/locale/lv/LC_MESSAGES/Horde_Block.po
  delete mode 100644 framework/Block/locale/mk/LC_MESSAGES/Horde_Block.po
  delete mode 100644 framework/Block/locale/nb/LC_MESSAGES/Horde_Block.mo
  delete mode 100644 framework/Block/locale/nb/LC_MESSAGES/Horde_Block.po
  delete mode 100644 framework/Block/locale/nl/LC_MESSAGES/Horde_Block.mo
  delete mode 100644 framework/Block/locale/nl/LC_MESSAGES/Horde_Block.po
  delete mode 100644 framework/Block/locale/nn/LC_MESSAGES/Horde_Block.mo
  delete mode 100644 framework/Block/locale/nn/LC_MESSAGES/Horde_Block.po
  delete mode 100644 framework/Block/locale/pl/LC_MESSAGES/Horde_Block.mo
  delete mode 100644 framework/Block/locale/pl/LC_MESSAGES/Horde_Block.po
  delete mode 100644 framework/Block/locale/pt/LC_MESSAGES/Horde_Block.mo
  delete mode 100644 framework/Block/locale/pt/LC_MESSAGES/Horde_Block.po
  delete mode 100644 framework/Block/locale/pt_BR/LC_MESSAGES/Horde_Block.mo
  delete mode 100644 framework/Block/locale/pt_BR/LC_MESSAGES/Horde_Block.po
  delete mode 100644 framework/Block/locale/ro/LC_MESSAGES/Horde_Block.mo
  delete mode 100644 framework/Block/locale/ro/LC_MESSAGES/Horde_Block.po
  delete mode 100644 framework/Block/locale/ru/LC_MESSAGES/Horde_Block.mo
  delete mode 100644 framework/Block/locale/ru/LC_MESSAGES/Horde_Block.po
  delete mode 100644 framework/Block/locale/sk/LC_MESSAGES/Horde_Block.mo
  delete mode 100644 framework/Block/locale/sk/LC_MESSAGES/Horde_Block.po
  delete mode 100644 framework/Block/locale/sl/LC_MESSAGES/Horde_Block.mo
  delete mode 100644 framework/Block/locale/sl/LC_MESSAGES/Horde_Block.po
  delete mode 100644 framework/Block/locale/sv/LC_MESSAGES/Horde_Block.mo
  delete mode 100644 framework/Block/locale/sv/LC_MESSAGES/Horde_Block.po
  delete mode 100644 framework/Block/locale/tr/LC_MESSAGES/Horde_Block.mo
  delete mode 100644 framework/Block/locale/tr/LC_MESSAGES/Horde_Block.po
  delete mode 100644 framework/Block/locale/uk/LC_MESSAGES/Horde_Block.mo
  delete mode 100644 framework/Block/locale/uk/LC_MESSAGES/Horde_Block.po
  delete mode 100644 framework/Block/locale/zh_CN/LC_MESSAGES/Horde_Block.po
  delete mode 100644 framework/Block/locale/zh_TW/LC_MESSAGES/Horde_Block.po
  delete mode 100644 framework/Block/package.xml
  create mode 100644 framework/Core/lib/Horde/Core/Block.php
  create mode 100644 framework/Core/lib/Horde/Core/Block/Layout.php
  create mode 100644 framework/Core/lib/Horde/Core/Block/Layout/Manager.php
  create mode 100644 framework/Core/lib/Horde/Core/Block/Layout/View.php
http://git.horde.org/horde-git/-/commit/42f3e499d48b29804c7aad91a6ca15363b18c017
02/12/2011 11:48:13 AM Git Commit Comment #3 Reply to this comment
Changes have been made in Git for this ticket:

Bug #9575: Temporary fix to load existing portals again.

http://git.horde.org/horde-git/-/commit/16d05e3a8c745eaa8551d7783e5619c29a086c63
02/12/2011 11:48:07 AM Git Commit Comment #2 Reply to this comment
Changes have been made in Git for this ticket:

Bug #9575: Fix variable name.

http://git.horde.org/horde-git/-/commit/4da2fce18e34d64c9f13dfd47ad71f0c3f792fe4
02/11/2011 09:49:50 PM Michael Slusarz Comment #1
Milestone ⇒ 4
State ⇒ Assigned
Patch ⇒ No
Assigned to Horde DevelopersHorde Developers
Assigned to Michael Slusarz
Queue ⇒ Horde Framework Packages
Summary ⇒ Horde_Block rewrite
Type ⇒ Bug
Priority ⇒ 3. High
Reply to this comment
Preemptive bug report - I am aware that blocks aren't working properly 
now.  The old code is kind of a mess and needs to be converted to 
H4/PHP 5 standards immediately (so it can be tested before H4 stable 
is released).  Additionally, the portal code in IMP (DIMP) needs to be 
moved into the framework block code.

Saved Queries