Tickets :: [#9539] Application names might not get translated

6.0.0-beta1

7/16/25

Summary	Application names might not get translated
Queue	Horde Framework Packages
Queue Version	Git master
Type	Bug
State	Not A Bug
Priority	1. Low
Owners	Horde Developers (at) , slusarz (at) horde (dot) org
Requester	goncalo.queiros (at) portugalmail (dot) net
Created	01/25/2011 (5286 days ago)
Due
Updated	01/27/2011 (5284 days ago)
Assigned	01/25/2011 (5286 days ago)
Resolved	01/27/2011 (5284 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	No

01/27/2011 12:34:21 PM	goncalo (dot) queiros (at) portugalmail (dot) net	Comment #11	Reply to this comment
Ok, close it then...don' t know if this is stated anywere, and if it's not, shouldn't it be?

01/27/2011 12:30:51 PM	Jan Schneider	Comment #10 State ⇒ Not A Bug Patch ⇒ No	Reply to this comment
Exactly

01/27/2011 11:22:38 AM	goncalo (dot) queiros (at) portugalmail (dot) net	Comment #9	Reply to this comment
Ok, Jan is correct, when building imp.mo the horde translations are merged in.. The problem appeared because i changed a horde sentence from _("Mail") to _("mail"), and only recreated the horde.mo.. This led to imp.mo having the translation for _("Mail") (from previous merge), but not the new one _("mail"). I think that what this says is that everytime you update horde translations you should update all your apps translations no?

01/25/2011 09:56:04 PM	Michael Slusarz	State ⇒ Feedback Assigned to Horde Developers

01/25/2011 09:55:43 PM	CVS Commit	Comment #8	Reply to this comment
Changes have been made in CVS for this ticket: ~~Bug: 9539~~ Revert 1.243.2.42 http://cvs.horde.org/diff.php/framework/Horde/Horde/Attic/Registry.php?rt=horde&r1=1.243.2.42&r2=1.243.2.43&ty=u

01/25/2011 09:51:52 PM	Git Commit	Comment #7	Reply to this comment
Changes have been made in Git for this ticket: Revert "~~Bug #9539~~: Correct translations for application names" This reverts commit 9514d8c72c0ccda884094e3bdecfa2a6911d0264. http://git.horde.org/horde-git/-/commit/9df4a0c5d1bc3b191ad477211eeec5c395e1ef61

01/25/2011 09:49:26 PM	Jan Schneider	Comment #6 State ⇒ Assigned	Reply to this comment
Please revert. All Horde translations are merged into any application's translation. There must be a different reason if this doesn't work properly. Needless to say this works perfectly fine in Horde 3.

01/25/2011 05:29:04 PM	Michael Slusarz	Comment #5 State ⇒ Resolved Assigned to Michael Slusarz	Reply to this comment
Patch cleaned up and applied. Also added to H3.

01/25/2011 05:28:57 PM	CVS Commit	Comment #4	Reply to this comment
Changes have been made in CVS for this ticket: ~~Bug: 9539~~ Merge from git HEAD: 9514d8c http://cvs.horde.org/diff.php/framework/Horde/Horde/Attic/Registry.php?rt=horde&r1=1.243.2.41&r2=1.243.2.42&ty=u

01/25/2011 05:25:49 PM	Git Commit	Comment #3	Reply to this comment
Changes have been made in Git for this ticket: ~~Bug #9539~~: Correct translations for application names http://git.horde.org/horde-git/-/commit/9514d8c72c0ccda884094e3bdecfa2a6911d0264

01/25/2011 01:25:47 PM	goncalo (dot) queiros (at) portugalmail (dot) net	Comment #2 New Attachment: 0001-Use-horde-translations-when-returning-an-application[1].patch	Reply to this comment
There were obvious problems with the first patch, ignore it :-) This one seems better...

01/25/2011 01:17:53 PM	goncalo (dot) queiros (at) portugalmail (dot) net	Comment #1 Priority ⇒ 1. Low State ⇒ Unconfirmed New Attachment: 0001-Use-horde-translations-when-returning-an-application.patch Patch ⇒ Yes Milestone ⇒ Queue ⇒ Horde Framework Packages Summary ⇒ Application names might not get translated Type ⇒ Bug	Reply to this comment
This is a odd problem. Currently all application names are being translated, but i think that this is happening luckley. When we call $registry->get('name', $app), the name will be translated according to the .mo of the current application, but application names are actually translated in horde.mo because they are present on registry.php.dist file. We are seeing every app name translated because for example imp.mo contains the translation for "Mail"...but if i go to registry.php.dist and make imp name = "Super Mail Client", then calling $registry->get('name', 'imp') with imp being the active app, i won't get the translation, since its not present on imp.mo. I attached a patch, but i don't know if this is the correct way of fixing the problem.