6.0.0-beta1
7/5/25

[#9528] Horde_Text_Filter_Cleanhtml
Summary Horde_Text_Filter_Cleanhtml
Queue Horde Framework Packages
Queue Version Git master
Type Enhancement
State Resolved
Priority 1. Low
Owners slusarz (at) horde (dot) org
Requester rsalmon (at) mbpgroup (dot) com
Created 01/20/2011 (5280 days ago)
Due
Updated 01/20/2011 (5280 days ago)
Assigned
Resolved 01/20/2011 (5280 days ago)
Milestone
Patch No

History
01/20/2011 08:58:29 PM Michael Slusarz Assigned to Michael Slusarz
State ⇒ Resolved
 
01/20/2011 08:58:19 PM Git Commit Comment #3 Reply to this comment
Changes have been made in Git for this ticket:

Bug #9528: Fix Windows-1258 conversion
Remove workaround for broken iconv() added here:

http://git.horde.org/co.php/framework/Util/Attic/String.php?sa=1&rt=horde&r=1.19

There's no PHP bug referenced, and I can't find any.  Adding this
extra character breaks Windows-1258 conversion.
If it was a bug in 2003, hopefully it has been fixed by now (all unit
tests pass).

http://git.horde.org/horde-git/-/commit/311a4e0c459a459b49512631fd86a40f3a2468d5
01/20/2011 07:55:50 PM Michael Slusarz Comment #2
State ⇒ Feedback
Reply to this comment
Tidy is not the problem - it is working perfectly.

The problem is converting the text from the UTF-8 output from tidy 
back to the original charset, in this case Windows-1258.  The 
Horde_String::convertCharset() call is returning only a partial string.
01/20/2011 01:09:41 PM rsalmon (at) mbpgroup (dot) com Comment #1
Priority ⇒ 1. Low
New Attachment: email.eml Download
Patch ⇒ No
Milestone ⇒
Queue ⇒ Horde Framework Packages
Summary ⇒ Horde_Text_Filter_Cleanhtml
Type ⇒ Enhancement
State ⇒ New
Reply to this comment
the attached email doesn't render using git-IMP

If I save the HTML part and open it using FF with Firebug enabled, 
Firefox doesn't complain and there isn't any error in Firebug.

If I disable tidy, it shows fine in IMP.

As far as I understand, Horde and Horde apps are not the one to blame 
. So, is it possible to provide a configuration option to disable the 
use of tidy or (even better) use an other HTML cleaner (I'm not aware 
of any alternative, just hopping something more up-to-date exists) ?




Saved Queries