Tickets :: [#9473] PHP ERROR: imp/lib/Prefs/Identity.php

6.0.0-beta1

7/17/25

Summary	PHP ERROR: imp/lib/Prefs/Identity.php
Queue	IMP
Queue Version	Git master
Type	Bug
State	Resolved
Priority	1. Low
Owners	jan (at) horde (dot) org
Requester	rsalmon (at) mbpgroup (dot) com
Created	12/28/2010 (5315 days ago)
Due
Updated	12/29/2010 (5314 days ago)
Assigned	12/28/2010 (5315 days ago)
Resolved	12/29/2010 (5314 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	No

12/29/2010 04:12:06 PM	Jan Schneider	Assigned to Jan Schneider State ⇒ Resolved

12/29/2010 04:06:39 PM	rsalmon (at) mbpgroup (dot) com	Comment #8	Reply to this comment
Try that? Looks good, Thanks.

12/29/2010 03:30:02 PM	Jan Schneider	Comment #7	Reply to this comment
Try that?

12/29/2010 03:29:58 PM	Git Commit	Comment #6	Reply to this comment
Changes have been made in Git for this ticket: Cast to array (~~Bug #9473~~). http://git.horde.org/horde-git/-/commit/d2e8692d48e3ad62da345138af96b17ded80477b

12/29/2010 11:06:37 AM	rsalmon (at) mbpgroup (dot) com	Comment #5	Reply to this comment
possible patch : --- Identity.php.org 2010-12-29 12:04:56.000000000 +0100 +++ Identity.php 2010-12-29 12:04:59.000000000 +0100 @@ -230 +230 @@ - $this->getValue('alias_addr', $ident), + (is_null($this->getValue('alias_addr', $ident)) ? array() : $this->getValue('alias_addr', $ident)),

12/29/2010 10:06:48 AM	Jan Schneider	Comment #4	Reply to this comment
Sorry, I should have mention the steps to reproduce. using dynamic view, prefs alias_addr and replyto_addr are empty and locked. After login and accessing the dynamic view, I get hundreds of PHP ERROR in /tmp/horde.log. This is because all (silenced) errors are logged now. I'm not perfectly happy with that change, but it's a completely different topic. alias_addr is supposed to be an array. If you wrap it, you have a two-dimensional array. And it's already silenced for the case when it's not an array. the structure of pref alias_addr looks exactly the same as replyto_addr. So, I guess (in imp/lib/Prefs/Identity.php) alias_addr should be wrap like replyto_addr is. No, replyto_addr is a single value preference.

12/29/2010 09:49:42 AM	rsalmon (at) mbpgroup (dot) com	Comment #3	Reply to this comment
Sorry, I should have mention the steps to reproduce. using dynamic view, prefs alias_addr and replyto_addr are empty and locked. After login and accessing the dynamic view, I get hundreds of PHP ERROR in /tmp/horde.log. alias_addr is supposed to be an array. If you wrap it, you have a two-dimensional array. And it's already silenced for the case when it's not an array. the structure of pref alias_addr looks exactly the same as replyto_addr. So, I guess (in imp/lib/Prefs/Identity.php) alias_addr should be wrap like replyto_addr is.

12/28/2010 04:51:02 PM	Jan Schneider	Comment #2 State ⇒ Feedback	Reply to this comment
alias_addr is supposed to be an array. If you wrap it, you have a two-dimensional array. And it's already silenced for the case when it's not an array.

12/28/2010 11:14:23 AM	rsalmon (at) mbpgroup (dot) com	Comment #1 Milestone ⇒ State ⇒ Unconfirmed Patch ⇒ No Queue ⇒ IMP Summary ⇒ PHP ERROR: imp/lib/Prefs/Identity.php Type ⇒ Bug Priority ⇒ 1. Low	Reply to this comment
2010-12-28T12:04:28+01:00 DEBUG: HORDE [imp] PHP ERROR: array_merge(): Argument #1 is not an array [pid 27323 on line 232 of "/var/www/html/hordetest/imp/lib/Prefs/Identity.php"] --- Identity.php.old 2010-12-28 12:08:43.000000000 +0100 +++ Identity.php 2010-12-28 12:08:48.000000000 +0100 @@ -230 +230 @@ - $this->getValue('alias_addr', $ident), + array($this->getValue('alias_addr', $ident)),