Tickets :: [#9430] Share doesn't log Db errors

6.0.0-beta1

9/2/25

Summary	Share doesn't log Db errors
Queue	Horde Framework Packages
Queue Version	Git master
Type	Bug
State	Resolved
Priority	1. Low
Owners	mrubinsk (at) horde (dot) org
Requester	jan (at) horde (dot) org
Created	12/06/2010 (5384 days ago)
Due
Updated	12/07/2010 (5383 days ago)
Assigned	12/06/2010 (5384 days ago)
Resolved	12/07/2010 (5383 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	No

12/07/2010 03:15:36 PM	Michael Rubinsky	State ⇒ Resolved

12/07/2010 03:13:25 PM	Git Commit	Comment #5	Reply to this comment
Changes have been made in Git for this ticket: Clean up exceptions and logging. Inject Horde_Log_Logger, don't log exceptions from Horde_Db_Adapter when running queries, since those would be logged by the adapter, don't log queries in client code, it's logged by the adapter. Partially relates to ~~Bug: 9430~~ http://git.horde.org/horde-git/-/commit/14800f5a422cf05a2a1e01394488273b5da7232f

12/07/2010 03:13:12 PM	Git Commit	Comment #4	Reply to this comment
Changes have been made in Git for this ticket: Exceptions should be logged at error level, not debug. ~~Bug: 9430~~ http://git.horde.org/horde-git/-/commit/864d3e31153b28c99b9a21962ddfff18a54375d0

12/06/2010 04:26:37 PM	Michael Rubinsky	State ⇒ Assigned

12/06/2010 04:12:10 PM	jan (at) horde (dot) org	Comment #3	Reply to this comment
This was a duplicate key error when creating a new calendar, because I didn't run the migration scripts yet.

12/06/2010 02:04:33 PM	Michael Rubinsky	Comment #2 State ⇒ Feedback	Reply to this comment
The db adapter injected into shares is obtained from the injector, so this would affect any Horde_Db using code (if its due to no attached logger). What were you doing when you got the error, and do you know what the error was?

12/06/2010 10:58:46 AM	Jan Schneider	Comment #1 Priority ⇒ 1. Low Type ⇒ Bug Summary ⇒ Share doesn't log Db errors Queue ⇒ Horde Framework Packages Assigned to Michael Rubinsky Milestone ⇒ Patch ⇒ No State ⇒ Assigned	Reply to this comment
Maybe the Horde_Db object injected into Horde_Share doesn't have a logger attached, but I just got an SQL error from Kronolith's shares that hasn't been logged to the Horde log.