Tickets :: [#9334] Sending message is ignoring Cc and Bcc fields

6.0.0-alpha12

6/6/25

Summary	Sending message is ignoring Cc and Bcc fields
Queue	IMP
Queue Version	Git master
Type	Bug
State	Resolved
Priority	1. Low
Owners	slusarz (at) horde (dot) org
Requester	goncalo.queiros (at) portugalmail (dot) net
Created	10/22/2010 (5341 days ago)
Due
Updated	10/29/2010 (5334 days ago)
Assigned
Resolved	10/22/2010 (5341 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	Yes

10/29/2010 08:45:48 PM	Git Commit	Comment #7	Reply to this comment
Changes have been made in Git for this ticket: ~~Bug #9334~~: Rework Cc/Bcc display in DIMP ONLY show Cc/Bcc fields in dimp if compose_[b]cc pref is set. Locked value is irrelevant. This matches behavior in IMP. Improved location of Show Cc/Bcc button in dimp. http://git.horde.org/diff.php/imp/compose-dimp.php?rt=horde-git&r1=00c63fa70475450522f1f98b802f50a7c6cbb5bd&r2=008e81af5b4fe0e2ee95a63f3a6c1cca9da03b2a http://git.horde.org/diff.php/imp/js/compose-dimp.js?rt=horde-git&r1=59a861cd78d3c6df9cdbd405731572d614964a4f&r2=008e81af5b4fe0e2ee95a63f3a6c1cca9da03b2a http://git.horde.org/diff.php/imp/lib/Ajax/Application.php?rt=horde-git&r1=59a861cd78d3c6df9cdbd405731572d614964a4f&r2=008e81af5b4fe0e2ee95a63f3a6c1cca9da03b2a http://git.horde.org/diff.php/imp/lib/Views/Compose.php?rt=horde-git&r1=00c63fa70475450522f1f98b802f50a7c6cbb5bd&r2=008e81af5b4fe0e2ee95a63f3a6c1cca9da03b2a http://git.horde.org/diff.php/imp/message-dimp.php?rt=horde-git&r1=1121fb4fdde21774156cca072cbce4f6aac49313&r2=008e81af5b4fe0e2ee95a63f3a6c1cca9da03b2a http://git.horde.org/diff.php/imp/templates/dimp/compose/compose.html?rt=horde-git&r1=5f103ca671950049ca293b37d9c456f0812cd488&r2=008e81af5b4fe0e2ee95a63f3a6c1cca9da03b2a http://git.horde.org/diff.php/imp/themes/dimp/screen.css?rt=horde-git&r1=d36c736cd102e9d8d3a38a3da91d8f67d614fafa&r2=008e81af5b4fe0e2ee95a63f3a6c1cca9da03b2a

10/27/2010 07:18:42 AM	goncalo (dot) queiros (at) portugalmail (dot) net	Comment #6	Reply to this comment
So if i lock this pref (so the users can't change its value through options page), and still want the Cc and Bcc fields to not show by default, i can't do it, since locking it and setting it's value to 0 will not give me the option to show the Cc and Bcc is that it? Yes. Ok, it seems a bit strange, and its also not working btw. Locking the pref will not remove the 2 checkboxes to add the Cc and Bcc

10/26/2010 11:13:45 PM	Michael Slusarz	Comment #5	Reply to this comment
So if i lock this pref (so the users can't change its value through options page), and still want the Cc and Bcc fields to not show by default, i can't do it, since locking it and setting it's value to 0 will not give me the option to show the Cc and Bcc is that it? Yes.

10/25/2010 04:51:14 PM	goncalo (dot) queiros (at) portugalmail (dot) net	Comment #4	Reply to this comment
But you are also partially incorrect - since if compose_[b]cc is locked, we don't want to allow a user to add those values even by form manipulation. So I added a locked check in dimp. So if i lock this pref (so the users can't change its value through options page), and still want the Cc and Bcc fields to not show by default, i can't do it, since locking it and setting it's value to 0 will not give me the option to show the Cc and Bcc is that it?

10/22/2010 05:19:14 PM	Michael Slusarz	Comment #3 Assigned to Michael Slusarz State ⇒ Resolved	Reply to this comment
When sending a message with Cc and Bcc fields, these addresses are being ignored, because we are looking at the value of compose_cc and compose_bcc prefs to decide if we should include those values in the header of the message. For dimp you are partially correct - since we allow Showing Cc/Bcc after the page is loaded. But you are also partially incorrect - since if compose_[b]cc is locked, we don't want to allow a user to add those values even by form manipulation. So I added a locked check in dimp. However, in imp, there is no way to show Cc/Bcc if it is disabled in prefs. So we need to ignore any cc/bcc data passed in the form. The rest of the patch, slightly modified and cleaned up, was applied as-is.

10/22/2010 05:17:39 PM	Git Commit	Comment #2	Reply to this comment
Changes have been made in Git for this ticket: ~~Bug #9334~~: Cc/Bcc display fixes Based on patch from Gonçalo Queirós <goncalo.queiros@portugalmail.net> http://git.horde.org/diff.php/imp/js/compose-dimp.js?rt=horde-git&r1=5f103ca671950049ca293b37d9c456f0812cd488&r2=59a861cd78d3c6df9cdbd405731572d614964a4f http://git.horde.org/diff.php/imp/js/dimpbase.js?rt=horde-git&r1=e12601f83f10888188b977231c1ba3e75bcdc6ae&r2=59a861cd78d3c6df9cdbd405731572d614964a4f http://git.horde.org/diff.php/imp/lib/Ajax/Application.php?rt=horde-git&r1=e8865ecdcaae2987d2eba3e1b72eeaf169e37f45&r2=59a861cd78d3c6df9cdbd405731572d614964a4f http://git.horde.org/diff.php/imp/lib/Views/ShowMessage.php?rt=horde-git&r1=1121fb4fdde21774156cca072cbce4f6aac49313&r2=59a861cd78d3c6df9cdbd405731572d614964a4f http://git.horde.org/diff.php/imp/templates/dimp/index.inc?rt=horde-git&r1=00c63fa70475450522f1f98b802f50a7c6cbb5bd&r2=59a861cd78d3c6df9cdbd405731572d614964a4f

10/22/2010 03:41:23 PM	goncalo (dot) queiros (at) portugalmail (dot) net	Comment #1 Priority ⇒ 1. Low Type ⇒ Bug Summary ⇒ Sending message is ignoring Cc and Bcc fields Queue ⇒ IMP Milestone ⇒ Patch ⇒ Yes New Attachment: 0001-Don-t-use-compose_cc-and-compose_bcc-prefs-to-decide.patch State ⇒ Unconfirmed	Reply to this comment
When sending a message with Cc and Bcc fields, these addresses are being ignored, because we are looking at the value of compose_cc and compose_bcc prefs to decide if we should include those values in the header of the message. Correcting this issue i also found out that Horde is not showing the Bcc field on the headers of the message. The problem is that on drafts, there may exist value on the Bcc field, so the patch also corrects this. Also, when resuming a draft, Horde should show the Cc and Bcc if they have any value (regardless of their pref) Patch corrects all this issues