Summary | Services cache is not issuing the correct headers |
Queue | Horde Base |
Queue Version | Git master |
Type | Bug |
State | Resolved |
Priority | 1. Low |
Owners | slusarz (at) horde (dot) org |
Requester | goncalo.queiros (at) portugalmail (dot) net |
Created | 10/18/2010 (5375 days ago) |
Due | |
Updated | 10/20/2010 (5373 days ago) |
Assigned | 10/19/2010 (5374 days ago) |
Resolved | 10/20/2010 (5373 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | Yes |
Assigned to Michael Slusarz
State ⇒ Feedback
Bug #9315: Fix setting session_cache_limiter valuehttp://git.horde.org/diff.php/framework/Core/lib/Horde/Registry.php?rt=horde-git&r1=6a4848780fcdbe9dd430175f68eff007ac91b62c&r2=0ab36983a478f9137f04e428f85ccd389e617710
http://git.horde.org/diff.php/framework/Core/lib/Horde/Session.php?rt=horde-git&r1=e5d48db80a4a9ac4916ac534130c8f145d820466&r2=0ab36983a478f9137f04e428f85ccd389e617710
New Attachment: cache.diff
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ Services cache is not issuing the correct headers
Queue ⇒ Horde Base
Milestone ⇒
Patch ⇒ Yes
State ⇒ Unconfirmed
not getting the proper header, making them not cache-able by the
browser.
The problem is that cache.php issues a Horde_Registry::appInit, that
will then call the Registry constructor which in turn calls the
Horde_Session construct, where the session is started and the headers
are issued.
The problem is that the Horde_Session constructor is relying on the
existence of the $registry->initParams['session_cache_limiter']
variable:
session_cache_limiter(is_null($registry->initParams['session_cache_limiter'])
? $conf['session']['cache_limiter'] :
$registry->initParams['session_cache_limiter']);
But this params are only setted before the Horde_Registry is called,
thus the session_cache_limiter will only be called with the $conf
variable which value is 'nocache'.
I did solve the problem, but i don't think this is the intended way,
but i attach the patch anyway