Too bad.

Are you referring to the rewrite you mentioned on 09/13/10? Yes.
If you talk about a later rewrite, I have not tested it again because 
my management didn't allow for more months to wait until deploying a 
working solution. So we decided (sadly) to use a different software.

My resources are exhausted at the time, maybe I'll have in a couple of 
weeks time to look at the most recent H4 version in my spare time.

Is this still happening after the Horde_Group rewrite?

Ok, I checked the group staff as requested.

To get it work I had to modify framework/Auth/lib/Horde/Auth/Ldap.php 
(see Ticket #9196) and framework/Group/lib/Horde/Group/Ldap.php.
In Group/Ldap.php I had to change the names for the variables storing 
bind user and password (again ldiff -u attached).

Result: empty page by clicking on administration-Groups (only header 
and footer is shown but no groups are listed), clicking on shares in 
kronolith let me select the groups. Therefore I think it works, 
although no groups are listed.

Changes have been made in Git for this ticket:

Fix parse error (Bug #9197).

http://git.horde.org/diff.php/framework/Group/lib/Horde/Group/Ldap.php?rt=horde-git&r1=902b4483b0b40da51a1116905a8fdb46c0c4eb02&r2=8c8036716d2d7efe01f1ddc78437a42cdf765403

Hi Jan,

ok I pulled the whole thing from the scratch and applied my config.

I think there is an typoo in framework/Group/lib/Horde/Group/Ldap.php 
on line 459, I get
an syntax error "unexpected }"
changing the line
$cache[$group] = $res
to
$cache[$group] = $res; seems to work.
At least after login I can see the sidebar (without the ";" I only got 
the top menu).

Nevertheless I get a bunch of warnings in the apache log and 
horde.log. I will take a look at these tomorrow.

As I just wrote to the horde list, I get an error message when trying to pull.

git pull
dev.horde.org[0: 208.52.151.194]: errno=Connection refused
fatal: unable to connect a socket (Connection refused)

If just fixed a lot of stuff in the LDAP group driver which was 
completely broken. Can you try if the issues reported here have all 
been fixed now?

We're using Active Directory on Windows 2003 Server.
Yes.
At the moment I am using the version from 29th august.
In our setup the following error occurs:
[07-Sep-2010 13:30:50] PHP Warning:  implode(): Invalid arguments 
passed in /usr/share/php/Horde/Group/Ldap.php on line 498
(one error per Group is written)

var_dump($result); returns NULL -> where is this variable filled?
this is the function:
     public function getGroupParent($dn)
     {
         if (@ldap_explode_dn($dn, 0) === false) {
             throw new Horde_Group_Exception('Invalid group ID passed 
(bad DN syntax)');
         }
         unset($result['count'], $result[0]);

         $parent_dn = implode(',', $result);

         return (Horde_String::lower($parent_dn) == 
Horde_String::lower($GLOBALS['conf']['group']['params']['basedn']))
             ? DATATREE_ROOT
             : $parent_dn;
     }

When I click on a Group, following error occurs:
[07-Sep-2010 13:33:27] PHP Fatal error:  Call to protected method 
Horde_Group_LdapObject::_fromAttributes() from context 
'Horde_Group_Ldap' in /usr/share/php/Horde/Group/Ldap.php on line 251

Turning _from/_toAttributes to public functions works for me (means 
Groups are "clickable", but still empty).

What kind of LDAP Implementation do you have? Maybe this applies only 
to active directory servers.
I assume you mean Manage Calenders and then click on the prefernces icon.
Well, after the git pull on 24.8. I can not see this anymore in H4.
Nevertheless, in framework/Group/lib/Horde/Group/Ldap.php in function
  exists($group) the call of @ldap_compare doesn't work (at least with our AD).
I worked around by adding a stristr call if ldap_compare returns 'false'.
This works but it turned out that we now have errors in the apache log:
PHP Warning:  implode(): Invalid arguments passed
This was solved by modifying function getGroupParent($dn).
original code snippet:
if (@ldap_explode_dn($dn, 0) === false) {
             throw new Horde_Group_Exception('Invalid group ID passed 
(bad DN syntax)');
         }
added to this:
  else {
$result = @ldap_explode_dn($dn, 0);
}

I think it would be better to move this discussion to the horde list. 
The bug as first described is about improper variable names. As soon 
there are relevant new commits to git, I will have a look at this 
again. Maybe we will have to create a new ticket if this is really a 
bug in function getGroupParent.

Thank you, I changed the variables in Ldap.php, too -> works.
The group-listing does work for me (same configuration as in H3). What 
still doesn't work is to list the groups in an application (here: 
kronolith). In H3 we hacked the code to get it worked.
When you get the Groups in the admin-interface listed, could you 
check, whether the Groups are even listed in Kronoliths' 
calendar-adminpanel?

Setup: H4 latest git code and Active Directory on Windows 2000 Server

Clicking on Groups (logged in as administrator) returns the following
error:
A fatal error has occurred
Could not reach the LDAP server
[line 556 of .../horde/framework/Group/lib/Horde/Group/Ldap.php]

Looking at the code (horde/framework/Group/lib/Horde/Group/Ldap.php)
you find the folowing snippet:
        if (isset($this->_params['binddn'])) {
            $bind = @ldap_bind($this->_ds, $this->_params['binddn'],
                               $this->_params['password']);
        } else {
            $bind = @ldap_bind($this->_ds);
        }

        if (!$bind) {
            throw new Horde_Group_Exception('Could not bind to LDAP server');
        }

Well I don't know why one don't see the error "Could not bind to LDAP Server",
maybe it's overwritten by the following Horde_Group_Exeption from the
ldap_search call. Nevertheless, binddn is empty, so an anonymous bind is
tried. Windows 2008 AD Server prevents anonymous binds by default. I couldn't
find any setting in the conf.php named "binddn" nor any in conf.php.dist.
So I replaced those with searchdn (password with searchpw) and it works.

Note: The Group Listing is still empty (as in H3) but this seems to be 
another problem I'm trying to track down in the code.