6.0.0-alpha12
6/12/25

[#9188] off by one error in RSS feeds on portal page (number of articles to display)!
Summary off by one error in RSS feeds on portal page (number of articles to display)!
Queue IMP
Queue Version Git master
Type Bug
State Resolved
Priority 1. Low
Owners mrubinsk (at) horde (dot) org
Requester gavin.mccullagh (at) gcd (dot) ie
Created 08/19/2010 (5411 days ago)
Due
Updated 09/08/2010 (5391 days ago)
Assigned
Resolved 09/08/2010 (5391 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch Yes

History
09/08/2010 03:46:30 PM Michael Rubinsky State ⇒ Resolved
 
08/19/2010 10:14:10 PM Michael Rubinsky Comment #5
Assigned to Michael Rubinsky
Summary ⇒ off by one error in RSS feeds on portal page (number of articles to display)!
Priority ⇒ 1. Low
Reply to this comment
Committed, thanks!
08/19/2010 10:13:25 PM Git Commit Comment #4 Reply to this comment
Changes have been made in Git for this ticket:

Fix off by one error
Bug: 9188
Submitted By: gavin (dot) mccullagh (at) gcd (dot) ie

http://git.horde.org/diff.php/horde/lib/Block/feed.php?rt=horde-git&r1=fabc7e43b5dc1d9e651f5a343eb49266e46a0b63&r2=7981d3a7ef96c967da0ddc0862ceb5e208d04e54
08/19/2010 10:12:12 PM CVS Commit Comment #3 Reply to this comment
Changes have been made in CVS for this ticket:

Fix off by one error
Bug: 9188
Submitted by: gavin (dot) mccullagh (at) gcd (dot) ie
http://cvs.horde.org/diff.php/horde/lib/Block/feed.php?rt=horde&r1=1.1.2.1&r2=1.1.2.2&ty=u
08/19/2010 11:41:15 AM gavin (dot) mccullagh (at) gcd (dot) ie Comment #2 Reply to this comment
If this bug fix could be back-ported to Horde v3 that would be great 
so that the fix goes into Kolab.

Gavin
08/19/2010 11:30:41 AM gavin (dot) mccullagh (at) gcd (dot) ie Comment #1
Priority ⇒ 2. Medium
Type ⇒ Bug
Summary ⇒ off by one error in RSS feeds on portal page (number of articles to display)
Queue ⇒ IMP
Milestone ⇒
Patch ⇒ Yes
New Attachment: rss_limit_off_by_one.patch Download
State ⇒ Unconfirmed
Reply to this comment
Originally noted in latest Kolab v2.2.4
   https://issues.kolab.org/issue4496
but issue appears to also exist in latest Horde.
   
http://git.horde.org/co.php/horde/lib/Block/feed.php?r=fabc7e43b5dc1d9e651f5a343eb49266e46a0b63

If you add an RSS feed to the Horde portal page and specify N articles 
to be displayed, you will get N+1 articles displayed.

Attached is a patch that fixes this issue.

Saved Queries