6.0.0-beta1
8/10/25

[#9156] vacation/maildrop single quote in subject
Summary vacation/maildrop single quote in subject
Queue Ingo
Queue Version Git master
Type Bug
State Resolved
Priority 1. Low
Owners jan (at) horde (dot) org
Requester rsalmon (at) mbpgroup (dot) com
Created 07/28/2010 (5492 days ago)
Due
Updated 04/04/2011 (5242 days ago)
Assigned 04/04/2011 (5242 days ago)
Resolved 04/04/2011 (5242 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch Yes

History
04/04/2011 03:03:52 PM Jan Schneider State ⇒ Resolved
 
04/04/2011 02:53:24 PM rsalmon (at) mbpgroup (dot) com Comment #13 Reply to this comment
Now, works like a charm.

This is not related to the original issue, but you probably could add 
a sanity check on dates, ie date_start <= date_end

Thanks.
04/04/2011 02:30:36 PM Git Commit Comment #12 Reply to this comment
Changes have been made in Git for this ticket:

There is not charset parameter for script backends (Bug #9156).

  3 files changed, 15 insertions(+), 16 deletions(-)
http://git.horde.org/horde-git/-/commit/ef4abb06f887529e0bc387d8f125c6d42950bf66
04/04/2011 01:39:21 PM rsalmon (at) mbpgroup (dot) com Comment #11 Reply to this comment
Try that?
charset is not set. appart from that, it looks good.
I'm gonna wait for your fix to try more complex (accents and euro 
sign) messages.

2011-04-04T15:17:52+02:00 NOTICE: HORDE [ingo] PHP ERROR: Undefined 
index: charset [pid 29585 on line 155 of 
"/var/www/html/hordetest/ingo/lib/Script/Maildrop/Recipe.php"]
2011-04-04T15:17:52+02:00 DEBUG: 1. Ingo::updateScript() 
/var/www/html/hordetest/ingo/vacation.php:89
2. Ingo_Script_Maildrop->generate() 
/var/www/html/hordetest/ingo/lib/Ingo.php:257
3. Ingo_Script_Maildrop->generateVacation() 
/var/www/html/hordetest/ingo/lib/Script/Maildrop.php:158
4. Ingo_Script_Maildrop_Recipe->__construct() 
/var/www/html/hordetest/ingo/lib/Script/Maildrop.php:282
5. Horde::errorHandler() 
/var/www/html/hordetest/ingo/lib/Script/Maildrop/Recipe.php:155

2011-04-04T15:17:52+02:00 NOTICE: HORDE [ingo] PHP ERROR: Undefined 
index: charset [pid 29585 on line 157 of 
"/var/www/html/hordetest/ingo/lib/Script/Maildrop/Recipe.php"]
2011-04-04T15:17:52+02:00 DEBUG: 1. Ingo::updateScript() 
/var/www/html/hordetest/ingo/vacation.php:89
2. Ingo_Script_Maildrop->generate() 
/var/www/html/hordetest/ingo/lib/Ingo.php:257
3. Ingo_Script_Maildrop->generateVacation() 
/var/www/html/hordetest/ingo/lib/Script/Maildrop.php:158
4. Ingo_Script_Maildrop_Recipe->__construct() 
/var/www/html/hordetest/ingo/lib/Script/Maildrop.php:282
5. Horde::errorHandler() 
/var/www/html/hordetest/ingo/lib/Script/Maildrop/Recipe.php:157

04/04/2011 12:37:26 PM Jan Schneider Comment #10
State ⇒ Feedback
Reply to this comment
Try that?
04/04/2011 12:37:21 PM Git Commit Comment #9 Reply to this comment
Changes have been made in Git for this ticket:

Correctly escape vacation subjects with quote characters in Maildrop 
driver (Bug #9156).

  3 files changed, 12 insertions(+), 5 deletions(-)
http://git.horde.org/horde-git/-/commit/6c9a79ddb04f7ccf15e0db78bbca4d08bc5242eb
04/04/2011 12:09:25 PM Jan Schneider Deleted Original Message
 
02/20/2011 01:53:33 AM Chuck Hagenbuch Assigned to Jan Schneider
State ⇒ Assigned
 
08/11/2010 03:04:17 PM rsalmon (at) mbpgroup (dot) com Comment #8
New Attachment: ingo.patch
Reply to this comment
Ah, understood. And no, they don't work both the same way, that's 
the problem. Maildrop requires to upload 2 files through VFS which 
is not supported by the current infrastructure in Ingo. Thus there 
is some direct VFS access hacked into the maildop script classes, 
where they don't belong at all.
procmail needs (or may need) 2 files as well. And I think that 
procmail driver doesn't work either since ingo Vfs driver calls 
VFS::singleton.

I nearly find a way to fix maildrop (and may be procmail) drivers, see 
attach patch file.

The main problem I guess is that I couldn't find a way to create a 
Horde_Vfs object, since parameters are not stored like in other apps : 
in ingo, settings are set in backend file and in other apps, settings 
are set in app main config file.

So I modified function Horde/Core/Factory/Vfs.php:getVfs to get an 
extra parameter (see patch file).

The only *problem* is that I don't know how to get yet the actual 
reason inside function ingo/lib/Driver/Vfs.php:setScriptActive

Are you Ok with this approach ?

08/11/2010 12:25:27 PM Jan Schneider Comment #7 Reply to this comment
What I meant was : can I rely on procmail source code to fix 
maildrop VFS's problems ?
Both, procmail and maildrop, work the same way. It is just the file 
format that differs (I guess).
Ah, understood. And no, they don't work both the same way, that's the 
problem. Maildrop requires to upload 2 files through VFS which is not 
supported by the current infrastructure in Ingo. Thus there is some 
direct VFS access hacked into the maildop script classes, where they 
don't belong at all.
08/11/2010 12:13:46 PM rsalmon (at) mbpgroup (dot) com Comment #6 Reply to this comment
Is the procmail driver working ? Is so, I can try to provide a patch
based on the procmail driver.
That wouldn't fix the maildrop driver though. And both drivers might 
need different escaping techniques.
What I meant was : can I rely on procmail source code to fix maildrop 
VFS's problems ?
Both, procmail and maildrop, work the same way. It is just the file 
format that differs (I guess).


08/11/2010 12:00:18 PM Jan Schneider Comment #5 Reply to this comment
Is the procmail driver working ? Is so, I can try to provide a patch 
based on the procmail driver.
That wouldn't fix the maildrop driver though. And both drivers might 
need different escaping techniques.
08/11/2010 10:16:54 AM rsalmon (at) mbpgroup (dot) com Comment #4 Reply to this comment
I can't test this patch, because the maildrop driver is completely
broken at the moment. A few class name fixes were easy to fix, but
the driver has to be refactored to not implicitely rely on a VFS
driver, and to not access protected properties and methods.
I get those errors as well.
I'll have a look.
Is the procmail driver working ? Is so, I can try to provide a patch 
based on the procmail driver.


08/11/2010 09:52:25 AM rsalmon (at) mbpgroup (dot) com Comment #3 Reply to this comment
I can't test this patch, because the maildrop driver is completely 
broken at the moment. A few class name fixes were easy to fix, but 
the driver has to be refactored to not implicitely rely on a VFS 
driver, and to not access protected properties and methods.
I get those errors as well.
I'll have a look.
08/06/2010 05:13:05 PM Jan Schneider Comment #2
State ⇒ Feedback
Reply to this comment
I can't test this patch, because the maildrop driver is completely 
broken at the moment. A few class name fixes were easy to fix, but the 
driver has to be refactored to not implicitely rely on a VFS driver, 
and to not access protected properties and methods.
07/28/2010 04:15:18 PM rsalmon (at) mbpgroup (dot) com Comment #1
Priority ⇒ 1. Low
State ⇒ Unconfirmed
New Attachment: Recipe.patch Download
Patch ⇒ Yes
Milestone ⇒
Queue ⇒ Ingo
Summary ⇒ vacation/maildrop single quote in subject
Type ⇒ Bug
Reply to this comment
If Subject of vacation contains a single quote (which appends all the 
time in French, eg : Message d'absence. ), delivery of the vacation 
message fails.

see attached patch.

Saved Queries