Summary | vacation/maildrop single quote in subject |
Queue | Ingo |
Queue Version | Git master |
Type | Bug |
State | Resolved |
Priority | 1. Low |
Owners | jan (at) horde (dot) org |
Requester | rsalmon (at) mbpgroup (dot) com |
Created | 07/28/2010 (5492 days ago) |
Due | |
Updated | 04/04/2011 (5242 days ago) |
Assigned | 04/04/2011 (5242 days ago) |
Resolved | 04/04/2011 (5242 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | Yes |
This is not related to the original issue, but you probably could add
a sanity check on dates, ie date_start <= date_end
Thanks.
There is not charset parameter for script backends (
Bug #9156).3 files changed, 15 insertions(+), 16 deletions(-)
http://git.horde.org/horde-git/-/commit/ef4abb06f887529e0bc387d8f125c6d42950bf66
I'm gonna wait for your fix to try more complex (accents and euro
sign) messages.
2011-04-04T15:17:52+02:00 NOTICE: HORDE [ingo] PHP ERROR: Undefined
index: charset [pid 29585 on line 155 of
"/var/www/html/hordetest/ingo/lib/Script/Maildrop/Recipe.php"]
2011-04-04T15:17:52+02:00 DE
BUG: 1. Ingo::updateScript()/var/www/html/hordetest/ingo/vacation.php:89
2. Ingo_Script_Maildrop->generate()
/var/www/html/hordetest/ingo/lib/Ingo.php:257
3. Ingo_Script_Maildrop->generateVacation()
/var/www/html/hordetest/ingo/lib/Script/Maildrop.php:158
4. Ingo_Script_Maildrop_Recipe->__construct()
/var/www/html/hordetest/ingo/lib/Script/Maildrop.php:282
5. Horde::errorHandler()
/var/www/html/hordetest/ingo/lib/Script/Maildrop/Recipe.php:155
2011-04-04T15:17:52+02:00 NOTICE: HORDE [ingo] PHP ERROR: Undefined
index: charset [pid 29585 on line 157 of
"/var/www/html/hordetest/ingo/lib/Script/Maildrop/Recipe.php"]
2011-04-04T15:17:52+02:00 DE
BUG: 1. Ingo::updateScript()/var/www/html/hordetest/ingo/vacation.php:89
2. Ingo_Script_Maildrop->generate()
/var/www/html/hordetest/ingo/lib/Ingo.php:257
3. Ingo_Script_Maildrop->generateVacation()
/var/www/html/hordetest/ingo/lib/Script/Maildrop.php:158
4. Ingo_Script_Maildrop_Recipe->__construct()
/var/www/html/hordetest/ingo/lib/Script/Maildrop.php:282
5. Horde::errorHandler()
/var/www/html/hordetest/ingo/lib/Script/Maildrop/Recipe.php:157
State ⇒ Feedback
Correctly escape vacation subjects with quote characters in Maildrop
driver (
Bug #9156).3 files changed, 12 insertions(+), 5 deletions(-)
http://git.horde.org/horde-git/-/commit/6c9a79ddb04f7ccf15e0db78bbca4d08bc5242eb
State ⇒ Assigned
New Attachment: ingo.patch
the problem. Maildrop requires to upload 2 files through VFS which
is not supported by the current infrastructure in Ingo. Thus there
is some direct VFS access hacked into the maildop script classes,
where they don't belong at all.
procmail driver doesn't work either since ingo Vfs driver calls
VFS::singleton.
I nearly find a way to fix maildrop (and may be procmail) drivers, see
attach patch file.
The main problem I guess is that I couldn't find a way to create a
Horde_Vfs object, since parameters are not stored like in other apps :
in ingo, settings are set in backend file and in other apps, settings
are set in app main config file.
So I modified function Horde/Core/Factory/Vfs.php:getVfs to get an
extra parameter (see patch file).
The only *problem* is that I don't know how to get yet the actual
reason inside function ingo/lib/Driver/Vfs.php:setScriptActive
Are you Ok with this approach ?
maildrop VFS's problems ?
Both, procmail and maildrop, work the same way. It is just the file
format that differs (I guess).
problem. Maildrop requires to upload 2 files through VFS which is not
supported by the current infrastructure in Ingo. Thus there is some
direct VFS access hacked into the maildop script classes, where they
don't belong at all.
based on the procmail driver.
need different escaping techniques.
VFS's problems ?
Both, procmail and maildrop, work the same way. It is just the file
format that differs (I guess).
based on the procmail driver.
need different escaping techniques.
broken at the moment. A few class name fixes were easy to fix, but
the driver has to be refactored to not implicitely rely on a VFS
driver, and to not access protected properties and methods.
I'll have a look.
based on the procmail driver.
broken at the moment. A few class name fixes were easy to fix, but
the driver has to be refactored to not implicitely rely on a VFS
driver, and to not access protected properties and methods.
I'll have a look.
State ⇒ Feedback
broken at the moment. A few class name fixes were easy to fix, but the
driver has to be refactored to not implicitely rely on a VFS driver,
and to not access protected properties and methods.
Priority ⇒ 1. Low
State ⇒ Unconfirmed
New Attachment: Recipe.patch
Patch ⇒ Yes
Milestone ⇒
Queue ⇒ Ingo
Summary ⇒ vacation/maildrop single quote in subject
Type ⇒ Bug
time in French, eg : Message d'absence. ), delivery of the vacation
message fails.
see attached patch.