Summary | backends.php.dist does not load configuration stanzas in .d directory |
Queue | Ingo |
Queue Version | 1.2.3 |
Type | Bug |
State | Resolved |
Priority | 1. Low |
Owners | jan (at) horde (dot) org |
Requester | requate (at) univention (dot) de |
Created | 07/14/2010 (5506 days ago) |
Due | |
Updated | 03/10/2011 (5267 days ago) |
Assigned | 08/07/2010 (5482 days ago) |
Resolved | 03/10/2011 (5267 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | Yes |
Assigned to Jan Schneider
State ⇒ Resolved
files, in all applications.
- First of all, these changes should go into the development aka git
version of Horde and apps.
from horde/config/registry.d/
- The rationale for loading registry stanzas from a directory makes
sense, but what's the exact reason why you need this for backend
configuration files in Turba/Ingo?
strategy that is used for all other configuration files (at least in
Kolab) also to this one, given also that Kolab ships its own
10-kolab_backends_base.php to override the dist backends.php:
http://kolab.org/cgi-bin/viewcvs-kolab.cgi/server/kolab-webclient/ingo/configuration/ingo-1.2.3/
We applied the patch to be able to layer configurations (Horde, Kolab,
UCS) and ship 20-backends_ucs.php to have a standard clean path to
override (Horde, Kolab) settings if requirements change at some point.
Horde::loadConfiguration().
in Turba you were talking about is a Kolab modification that doesn't
exist upstream either.
I thought we already had some generic *.d/ loading code in Turba that
you were referring to.
So, let's reboot the discussion:
- First of all, these changes should go into the development aka git
version of Horde and apps.
- It looks like we only support .d style loading for registry files
from horde/config/registry.d/
- The rationale for loading registry stanzas from a directory makes
sense, but what's the exact reason why you need this for backend
configuration files in Turba/Ingo?
- If this going to be done correctly, it should be done in
Horde::loadConfiguration().
for sources.php? And if there was some support for config/*.d/
loading, you wouldn't have to write the patch. I asked you to look
into Turba as an *example* how to correctly load config files from a
*.d/ directory.
to provide the patch attached to this report: I took the following
kolab patch for turba as the example, and did *not* find a
corresponting code block in ingo-h3-1.2.3, so I thought it might be
helpful to file the patch for ingo/config/backends.php.
http://kolab.org/cgi-bin/viewcvs-kolab.cgi/server/kolab-webclient/turba/patches/turba-2.3.3/t_turba_HK_GW_ConfigurationOverride.diff?rev=1.1&content-type=text/vnd.viewcvs-markup
If you consider the patch as futile we would be glad for a hint as how
to choose an alternative approach to a conf.d-style solution in this
case. If you consider this patch as obsolete, feel free to close this
bug as invalid.
could not locate a config/sources.php or any place where any pattern
like config/*.d/*.php gets loaded. Thus we fixed this with the patch
attached.
for sources.php? And if there was some support for config/*.d/
loading, you wouldn't have to write the patch. I asked you to look
into Turba as an *example* how to correctly load config files from a
*.d/ directory.
not locate a config/sources.php or any place where any pattern like
config/*.d/*.php gets loaded. Thus we fixed this with the patch
attached.
State ⇒ Feedback
itself, but to the place(s) where config/source.php is loaded.
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ backends.php.dist does not load configuration stanzas in .d directory
Queue ⇒ Ingo
Milestone ⇒
Patch ⇒ Yes
New Attachment: t_ingo_HK_UV_ConfdStyleConfigurationOverride.diff
State ⇒ Unconfirmed
configuration stanzas from a backends.d directory. The code was copied
from the sources.php.dist in Turba.
This include loop seems to be missing in ingo 1.2.4 as well.