Summary | Transparent authentication not clearing the session |
Queue | Horde Framework Packages |
Queue Version | Git master |
Type | Bug |
State | Resolved |
Priority | 3. High |
Owners | slusarz (at) horde (dot) org |
Requester | jan (at) horde (dot) org |
Created | 06/08/2010 (5503 days ago) |
Due | |
Updated | 07/02/2010 (5479 days ago) |
Assigned | 06/28/2010 (5483 days ago) |
Resolved | 07/02/2010 (5479 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | No |
Bug #9085: Destroying a session counts as a clean sessionhttp://git.horde.org/diff.php/framework/Core/lib/Horde/Registry.php?rt=horde-git&r1=40c3c5f412af1f752b3bf42884aed3117eb07445&r2=372196c52889c31692bbbf2024538192805be3f7
to the login page the first time, so to speak.
Bug #9085: Only reset session ID once per page loadhttp://git.horde.org/diff.php/framework/Core/lib/Horde/Registry.php?rt=horde-git&r1=182c2abfa25d3cdc6c6a23a3771a6886dcdcde7e&r2=8e3e0edc6bb2e6460aa8f22da9372ee40d3f988e
Warning: session_regenerate_id() [function.session-regenerate-id]:
Cannot regenerate session id - headers already sent in
/usr/local/horde/horde/framework/Core/lib/Horde/Registry.php on line
1582
on the login page.
Trace:
1 0.0027 782592 {main}( ) ../login.php:0
2 0.1840 8413552 require(
'/usr/local/horde/horde/horde/templates/login/login.inc'
) ../login.php:315
3 0.1852 8414088 Horde_Notification_Handler->notify( $options = array
('listeners' => 'status') ) ../login.inc:15
4 0.1853 8414712 Horde_Notification_Handler_Decorator_Alarm->notify(
$options = array ('listeners' => array (0 => 'status'))
) ../Handler.php:284
5 0.1853 8414712 Horde_Alarm->notify( $user = 'mike', $load = ???,
$preload = ???, $exclude = ??? ) ../Alarm.php:54
6 0.1854 8415072 Horde_Alarm->listAlarms( $user = 'mike', $time =
NULL, $load = TRUE, $preload = TRUE ) ../Alarm.php:457
7 0.1864 8444504 Horde_Alarm->load( $user = 'mike', $preload = TRUE
) ../Alarm.php:177
8 0.1879 8583720 Horde_Registry->listApps( $filter = NULL, $assoc =
FALSE, $perms = 4 ) ../Alarm.php:117
9 0.3768 14849736 Horde_Registry->hasPermission( $app = 'ansel',
$perms = 4 ) ../Registry.php:618
10 0.3769 14850048 Horde_Registry->isAuthenticated( $options = array
('app' => 'ansel') ) ../Registry.php:1222
11 0.3769 14850128 Horde_Registry->getCleanSession( ) ../Registry.php:1676
12 0.3769 14850224 session_regenerate_id ( TRUE ) ../Registry.php:1582
side-effects of this issue also relies on checkAuthentication()
working properly, so I can't update it yet.
State ⇒ Feedback
Bug #9085: get clean session if doing transparent auth in a nonauthenticated Horde session
http://git.horde.org/diff.php/framework/Core/lib/Horde/Registry.php?rt=horde-git&r1=26a33b08c4d70abca71dc606d6669f2d0ec59f53&r2=7869819cbfd94103184a404de1ba08b10b9d0b7c
State ⇒ Assigned
Priority ⇒ 3. High
State ⇒ Unconfirmed
Patch ⇒ No
Milestone ⇒
Queue ⇒ Horde Framework Packages
Summary ⇒ Transparent authentication not clearing the session
Type ⇒ Bug
getCleanSession() is not called, making the session vulnerable to
session fixation and other side-effects.