Summary | drag and drop message to hidden folder |
Queue | IMP |
Queue Version | Git master |
Type | Bug |
State | Resolved |
Priority | 1. Low |
Owners | slusarz (at) horde (dot) org |
Requester | rsalmon (at) mbpgroup (dot) com |
Created | 04/28/2010 (5521 days ago) |
Due | |
Updated | 05/24/2010 (5495 days ago) |
Assigned | 04/28/2010 (5521 days ago) |
Resolved | 05/24/2010 (5495 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | No |
State ⇒ Resolved
Bug #8989: Fix folder list scrolling.Signed-off-by: Michael M Slusarz <slusarz@curecanti.org>
http://git.horde.org/diff.php/horde/js/dragdrop2.js?rt=horde-git&r1=35115b66c5d4d2309553647f475724ab58f9f8b5&r2=0736b67c4a6869d1e1452f2f025ac03ec176f4ea
the JS code. (For the record, I tested with FF 3.6 on Ubuntu and
WinXP).
Going to mark as not a bug. If you can provide further debug
information, we will reopen this ticket.
I have 150 folders and everything works as expected using Firefox.
If I understood correctly;
p[1] seems to be the size of the folder tree (folders that are
expanded) * some value (probably font height)
p[3] = p[1] + dim.height
I've noticed that when dealing with lots of folder, p[1] is always
bigger than window.innerHeight and that probably why it was always
scrolling back to the first folder of the tree.
--- dragdrop2.js.org 2010-05-24 16:33:50.000000000 +0200
+++ dragdrop2.js 2010-05-24 16:34:37.000000000 +0200
@@ -626,16 +626,16 @@
// speed[0] = this.lastCoord[0] - p[0];
//}
// Top scroll
- if (this.lastCoord[1] < p[1]) {
- speed[1] = this.lastCoord[1] - p[1];
+ if (this.lastCoord[1] <(window.innerHeight - dim.height)) {
+ speed[1] = this.lastCoord[1] - (window.innerHeight - dim.height);
}
// Scroll right
//if (this.lastCoord[0] > p[2]) {
// speed[0] = this.lastCoord[0] - p[2];
//}
// Scroll left
- if (this.lastCoord[1] > p[3]) {
- speed[1] = this.lastCoord[1] - p[3];
+ if (this.lastCoord[1] > (window.innerHeight - 10)) {
+ speed[1] = this.lastCoord[1] - (window.innerHeight - 10);
}
if (speed[0] || speed[1]) {
State ⇒ Not A Bug
JS code. (For the record, I tested with FF 3.6 on Ubuntu and WinXP).
Going to mark as not a bug. If you can provide further debug
information, we will reopen this ticket.
Troubleshooting' section in imp/docs/INSTALL.
Firebug seems to be happy and horde caches are disabled.
Firefox's cache was cleared as well as user's prefs.
I'll see if I can find something but I doubt it.
Troubleshooting' section in imp/docs/INSTALL.
State ⇒ Unconfirmed
State ⇒ Assigned
New Attachment: test-0000.mpeg.zip
I can't drag and drop a message to any of the last folders. when
dragging the message, the folder list automatically scroll back up
to the beginning of the folder list.
The attached video will probably explain better.
Priority ⇒ 1. Low
State ⇒ Unconfirmed
Patch ⇒ No
Milestone ⇒
Queue ⇒ IMP
Summary ⇒ drag and drop message to hidden folder
Type ⇒ Bug
I can't drag and drop a message to any of the last folders. when
dragging the message, the folder list automatically scroll back up to
the beginning of the folder list.
The attached video will probably explain better.