Summary | blacklist: disable in mail view, enable in ingo |
Queue | Ingo |
Queue Version | 1.2.3 |
Type | Bug |
State | Not A Bug |
Priority | 2. Medium |
Owners | |
Requester | frank.richter (at) hrz (dot) tu-chemnitz (dot) de |
Created | 04/16/2010 (5540 days ago) |
Due | |
Updated | 04/20/2010 (5536 days ago) |
Assigned | |
Resolved | 04/18/2010 (5538 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | No |
addresses to the lists or you don't. There is a big message when users
add an address, including a link to edit the list.
It has shown at our site that placing the "blacklist" in IMP on top of
every page leads to accidental adding of addresses to the blacklist
(and later discarded e-mails).
On the other hand this blacklist feature, accessible in Ingo, is useful.
Frank
- I want let Ingo set the blacklist.
- I don't want let Imp set the blacklist.
How to do that?
Thanks,
Frank
State ⇒ Not A Bug
registry allows to *set* the list. Not which one allows to read it.
What you want can't be done, because either you allow Ingo to set the
lists, or you don't.
Priority ⇒ 2. Medium
Type ⇒ Bug
Summary ⇒ blacklist: disable in mail view, enable in ingo
Queue ⇒ Ingo
Milestone ⇒
Patch ⇒ No
State ⇒ Unconfirmed
I'd like to do the following
1. disable the blacklist/whitelist "buttons" in mail index and mail view
2. keep blacklist/whitelist enabled in ingo
In horde/config/registry.php I removed 'mail/blacklistFrom',
'mail/whitelistFrom'
from provides for ingo. Result:
1. ok
2. blacklist/whitelist butons in ingo are visable, but not the function -
"Blacklist is not supported in the current filtering driver."
Proposed fix in ingo/lib/Script.php:
- if ($key !== false &&
($registry->hasMethod('mail/blacklistFrom') != 'ingo')) {
unset($this->_categories[$key]);
}
/* Determine if ingo should handle the whitelist. */
$key = array_search(INGO_STORAGE_ACTION_WHITELIST,
$this->_categories);
- if ($key !== false &&
($registry->hasMethod('mail/whitelistFrom') != 'ingo')) {
unset($this->_categories[$key]);
+ if ($key !== false &&
($registry->hasMethod('mail/showBlacklist') != 'ingo')) {
unset($this->_categories[$key]);
}
/* Determine if ingo should handle the whitelist. */
$key = array_search(INGO_STORAGE_ACTION_WHITELIST,
$this->_categories);
+ if ($key !== false &&
($registry->hasMethod('mail/showWhitelist') != 'ingo')) {
unset($this->_categories[$key]);
Result:
1. ok
2. ok
Regards,
Frank