Tickets :: [#8952] Notspam not working

6.0.0-alpha12

6/12/25

Summary	Notspam not working
Queue	IMP
Queue Version	Git master
Type	Bug
State	Resolved
Priority	1. Low
Owners	slusarz (at) horde (dot) org
Requester	goncalo.queiros (at) portugalmail (dot) net
Created	04/07/2010 (5545 days ago)
Due
Updated	04/12/2010 (5540 days ago)
Assigned
Resolved	04/07/2010 (5545 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	Yes

04/12/2010 08:25:57 PM	Git Commit	Comment #5	Reply to this comment
Changes have been made in Git for this ticket: ~~Bug #8952~~: Fix casting spam parameter to number http://git.horde.org/diff.php/imp/js/DimpBase.js?rt=horde-git&r1=8e662a4a7d28963cc28b2350fed6e873da5a9a57&r2=94b41e1d9de573dade424bab53644eec0c72cae2

04/08/2010 07:25:43 PM	CVS Commit	Comment #4	Reply to this comment
Changes have been made in Git for this ticket: ~~Bug #8952~~: Fix casting spam parameter to number http://git.horde.org/diff.php/imp/js/DimpBase.js?rt=horde-git&r1=8e662a4a7d28963cc28b2350fed6e873da5a9a57&r2=94b41e1d9de573dade424bab53644eec0c72cae2

04/07/2010 10:30:30 PM	Michael Slusarz	Comment #3 Assigned to Michael Slusarz State ⇒ Resolved	Reply to this comment
If the user tries to mark a message as notspam, it will in fact try to mark it as spam again, due to a wrong comparison. Attached the patch. Fixed in the more proper place (the javascript code should be converting the boolean value to a number value). Btw, if no program or email is defined to deal with the spam, its not possible to mark a message as spam/notspam, is this intended? Yes.

04/07/2010 10:29:18 PM	CVS Commit	Comment #2	Reply to this comment
Changes have been made in Git for this ticket: ~~Bug #8952~~: Fix casting spam parameter to number http://git.horde.org/diff.php/imp/js/DimpBase.js?rt=horde-git&r1=8e662a4a7d28963cc28b2350fed6e873da5a9a57&r2=2e4659df249f74b72f3a1ac9b04d52086d26f520

04/07/2010 04:13:09 PM	goncalo (dot) queiros (at) portugalmail (dot) net	Comment #1 Priority ⇒ 1. Low New Attachment: spam.diff Patch ⇒ Yes Milestone ⇒ Summary ⇒ Notspam not working Type ⇒ Bug State ⇒ Unconfirmed Queue ⇒ IMP	Reply to this comment
If the user tries to mark a message as notspam, it will in fact try to mark it as spam again, due to a wrong comparison. Attached the patch. Btw, if no program or email is defined to deal with the spam, its not possible to mark a message as spam/notspam, is this intended?