| Summary | Notifications do not show in setup/config |
| Queue | Horde Base |
| Queue Version | Git master |
| Type | Bug |
| State | Resolved |
| Priority | 1. Low |
| Owners | Horde Developers (at) , slusarz (at) horde (dot) org |
| Requester | mrubinsk (at) horde (dot) org |
| Created | 02/26/2010 (5609 days ago) |
| Due | |
| Updated | 03/12/2010 (5595 days ago) |
| Assigned | |
| Resolved | 03/12/2010 (5595 days ago) |
| Github Issue Link | |
| Github Pull Request | |
| Milestone | |
| Patch | No |
State ⇒ Resolved
know enough about the Horde_Form code to fix this there. But
Horde_Form shouldn't be adding javascript to the page at all -
inserting javascript into the page should be the sole responsibility
of the called script.
Bug #8886: Fix adding javascript fileshttp://git.horde.org/diff.php/horde/admin/setup/config.php?rt=horde-git&r1=3ee16453993960c5e043aa0eda708aa9b5027d8f&r2=46bbc28ae64b774ccf8fb72bff67361b6d81fcd6
Priority ⇒ 1. Low
Patch ⇒ No
Milestone ⇒
Assigned to
Assigned to Michael Slusarz
Queue ⇒ Horde Base
Summary ⇒ Notifications do not show in setup/config
Type ⇒ Bug
State ⇒ Assigned
causing a js error:
document.observe is not a function
http://localhost/horde/admin/setup/config.php?app=horde
Line 25
It's due to the fact that prototype is loaded after this is output to
the browser. I tried tracing this, and I *think* it's an issue
similar to one I had in Ansel where I was using output buffering to
get some HTML output before common-header was sent. I think that in
admin/config.php when $form is generated by Util::bufferOutput(), this
confuses the code that determines if we can send the javascript to the
browser. In Ansel, I fixed this by shuffling around where
common-header was output in relation to the javascript being added
etc... but I can't seem to figure this particular case out... I'll
keep trying, but someone with more familiarity with the notification
code will probably be quicker at this.