Tickets :: [#8827] CSS compressor getting inheritance wrong

6.0.0-beta1

11/8/25

Summary	CSS compressor getting inheritance wrong
Queue	Horde Framework Packages
Queue Version	Git master
Type	Bug
State	Resolved
Priority	1. Low
Owners	jan (at) horde (dot) org, slusarz (at) horde (dot) org
Requester	jan (at) horde (dot) org
Created	01/15/2010 (5776 days ago)
Due
Updated	07/28/2010 (5582 days ago)
Assigned	06/22/2010 (5618 days ago)
Resolved	07/28/2010 (5582 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	No

07/28/2010 02:46:35 AM	Michael Slusarz	Comment #6 State ⇒ Resolved	Reply to this comment
I don't have the time to track down why this doesn't work by default. This workaround fixes things though so that is enough for me.

06/25/2010 06:11:43 PM	Git Commit	Comment #5	Reply to this comment
Changes have been made in Git for this ticket: ~~Bug #8827~~: Need preserve_css off or else CSS array is not generated http://git.horde.org/diff.php/imp/view.php?rt=horde-git&r1=0a823c7ad6542a26dda34dbbc72a51c21fd0ac99&r2=958dd4887697289270da5a93189f24af479b210b

06/22/2010 03:23:37 PM	Michael Slusarz	Comment #4 Assigned to Michael Slusarz State ⇒ Assigned	Reply to this comment
Yep - this fix also breaks things. Header formatting in the IMP print screen in FF is now broken.

06/17/2010 10:00:20 PM	Michael Slusarz	Comment #3	Reply to this comment
No idea what this setting does, but it fixes ~~bug #8827~~. This preserves browser hacks. So this change might very well break things we do to fix various firefox version workarounds, for example.

06/17/2010 09:53:09 PM	Jan Schneider	Taken from Michael Slusarz State ⇒ Resolved Assigned to Jan Schneider

06/17/2010 09:52:01 PM	Git Commit	Comment #2	Reply to this comment
Changes have been made in Git for this ticket: No idea what this setting does, but it fixes ~~bug #8827~~. http://git.horde.org/diff.php/framework/Text_Filter_Csstidy/lib/Horde/Text/Filter/Csstidy.php?rt=horde-git&r1=9326547e493b8025bec6ddd708d2769d9af12167&r2=2e4efdb4f3b95bdbd82588da1221ca21dba2d124

01/15/2010 12:02:28 AM	Jan Schneider	New Attachment: screen.css

01/15/2010 12:02:16 AM	Jan Schneider	Comment #1 Priority ⇒ 1. Low State ⇒ Assigned Patch ⇒ No Milestone ⇒ Assigned to Michael Slusarz Queue ⇒ Horde Framework Packages Summary ⇒ CSS compressor getting inheritance wrong Type ⇒ Bug	Reply to this comment
See the attached theme for Kronolith, the "span#kronolithQuickEvent" rule. It's being merged with the base css, so that the "height: 16px" is used from the base theme. But the sapo theme also specifies "#kronolithAddEvents span" which has a lower precedence than "span#kronolithQuickEvent" from the theme, but a higher than "span#kronolithQuickEvent" from the base css (according to firebug). If loading the css files separately, the browser sorts this out, and renders the object with the "height: 20px" from the theme's "#kronolithAddEvents span". This doesn't work when the css are merged.