Tickets :: [#8757] Turba favourites driver does not provide removeUserData function

6.0.0-alpha12

6/8/25

Summary	Turba favourites driver does not provide removeUserData function
Queue	IMP
Queue Version	FRAMEWORK_3
Type	Enhancement
State	Rejected
Priority	1. Low
Owners
Requester	Valentin.Vidic (at) carnet (dot) hr
Created	12/07/2009 (5662 days ago)
Due
Updated	04/05/2010 (5543 days ago)
Assigned
Resolved	04/05/2010 (5543 days ago)
Milestone
Patch	No

04/05/2010 01:13:09 PM	Jan Schneider	State ⇒ Rejected

03/02/2010 02:59:52 PM	Michael Rubinsky	Comment #9 State ⇒ Feedback	Reply to this comment
[Show Quoted Text - 9 lines][Hide Quoted Text] Yes, the problem is that favourites is implemented in IMP but accessed through Turba. Turba calls removeUserData in turba/lib/Driver/favourites.php, but since this wasn't implemented an error was returned by the default implementation in turba/lib/Driver.php. So I added removeUserData to turba/lib/Driver/favourites.php but also had to create a new api call to pass the request to IMP. Don't know if there is a cleaner way to do this, perhaps by moving favourites functionality from IMP into Turba. I agree with Jan. Turba is only a consumer of the favorites data, IMP is responsible for it. You should change your patch to implement a removeUserData api inside of IMP itself. If you are concerned about getting an error message from Turba, I guess we can override the removeUserData method in favorites.php to have it simply return true, or perhaps a more accurate error message.

12/08/2009 11:33:38 AM	Valentin (dot) Vidic (at) carnet (dot) hr	Comment #8	Reply to this comment
Yes, the problem is that favourites is implemented in IMP but accessed through Turba. Turba calls removeUserData in turba/lib/Driver/favourites.php, but since this wasn't implemented an error was returned by the default implementation in turba/lib/Driver.php. So I added removeUserData to turba/lib/Driver/favourites.php but also had to create a new api call to pass the request to IMP. Don't know if there is a cleaner way to do this, perhaps by moving favourites functionality from IMP into Turba.

12/08/2009 10:53:17 AM	Jan Schneider	Comment #7 Patch ⇒ No State ⇒ Accepted	Reply to this comment
Okay, that's a use case that we should reconsider. But why are you overcomplicating things by adding a new API method and routing the deletion through Turba? Why don't you simply implement a removerUserData method in IMP's API?

12/08/2009 08:58:48 AM	Valentin (dot) Vidic (at) carnet (dot) hr	Comment #6	Reply to this comment
The case I have in mind is when a user is deleted from the system and a new one is created with the same username (this is not unusual in large installations with automatically generated usernames). For these cases I want to make sure all data from the old user is completely removed from the database. Leaving the favourites addressbook in the database allows the new user to see the mail recipients of the previous user.

12/07/2009 09:19:15 PM	Jan Schneider	Comment #5	Reply to this comment
I agree with Michael.

12/07/2009 07:58:38 PM	Michael Rubinsky	Comment #4	Reply to this comment
Ah, right, it garbage collects the storage and deletes all entries before a certain time. In that case, though, I still don't think it makes sense to add this, since those entries will be gc'd as more email is sent from other users anyway...

12/07/2009 07:47:45 PM	Chuck Hagenbuch	Comment #3	Reply to this comment
The information could be removed by IMP, though.

12/07/2009 06:50:49 PM	Michael Rubinsky	Comment #2	Reply to this comment
I could be wrong, but I believe this data could also be used for auditing and reporting purposes, so should not be deleted.

12/07/2009 06:48:56 PM	Michael Rubinsky	Version ⇒ FRAMEWORK_3 Queue ⇒ IMP State ⇒ Rejected

12/07/2009 04:27:29 PM	Valentin (dot) Vidic (at) carnet (dot) hr	Comment #1 Patch ⇒ Yes State ⇒ New New Attachment: favourites.diff Milestone ⇒ Queue ⇒ Horde Groupware Webmail Edition Summary ⇒ Turba favourites driver does not provide removeUserData function Type ⇒ Enhancement Priority ⇒ 1. Low	Reply to this comment
Turba API function removeUserData calls removeUserData for configured contact sources. Favourites driver does not implement this function and an error is returned: Removing user data is not supported in the current address book storage driver. Attached patch implements this functionality by adding a new function to IMP API.