| Summary | Week view events spans are incorrect |
| Queue | Kronolith |
| Queue Version | 2.3.2 |
| Type | Bug |
| State | Resolved |
| Priority | 2. Medium |
| Owners | jan (at) horde (dot) org |
| Requester | arnaud.didry (at) univ-avignon (dot) fr |
| Created | 11/18/2009 (5710 days ago) |
| Due | |
| Updated | 01/13/2010 (5654 days ago) |
| Assigned | 11/29/2009 (5699 days ago) |
| Resolved | 12/01/2009 (5697 days ago) |
| Github Issue Link | |
| Github Pull Request | |
| Milestone | 2.3.3 |
| Patch | No |
Fix obscure event layout bug (
Bug #8716). Untested, because I can'tlogin to git right now.
http://git.horde.org/diff.php/kronolith/lib/View/Week.php?rt=horde-git&r1=da2812a55a55da147580f9ca3002c42a307fb1f9&r2=cb6617eb017433e477a38cd582ad318167f91ddb
Queue ⇒ Kronolith
State ⇒ Resolved
Taken from
Assigned to Jan Schneider
MFG: Fix obscure event layout bug (
Bug #8716).http://cvs.horde.org/diff.php/kronolith/lib/Views/Week.php?rt=horde&r1=1.24.2.6&r2=1.24.2.7&ty=u
Fix obscure event layout bug (
Bug #8716). Untested, because I can'tlogin to git right now.
http://git.horde.org/diff.php/kronolith/lib/View/Week.php?rt=horde-hatchery&r1=da2812a55a55da147580f9ca3002c42a307fb1f9&r2=cb6617eb017433e477a38cd582ad318167f91ddb
State ⇒ Assigned
New Attachment: event_colspan_bug.patch
First, $event->indent was miscalculated because $hspan doesn't count
empties cells at the beginning of a day, which affected the
calculation of the coverage graph.
Once this bug was corrected, I found that the span was miscalculated
when collision occurs between two events : when the first half of an
event "A" (width indent=0) is in collision with another event "B"
(with indent=2); it was impossible to calculate the span of event "A"
once event "B" is finished, affecting the value of hspan and the
number of empties "td" appended at the end of a timeslot. To fix this,
I stored the span of an event at its first computation.
The problem of colspan float values is still present, I temporary
fixed it with "ceil()" but I think that another ticket needs to be
opened.
It's not related to the bug, but I added a css class to empty cells
between each day to be able to easily add color to them.
Everything seems to work now, I just need to do some more tests.
Sorry for my poor english, some comments in the patch may need to be
rewritten.
Patch ⇒ No
State ⇒ Unconfirmed
New Attachment: screenshot.png
Milestone ⇒
Queue ⇒ Horde Groupware Webmail Edition
Summary ⇒ Week view events spans are incorrect
Type ⇒ Bug
Priority ⇒ 2. Medium
As you can see in the screenshot, colspan are incorrectly calculated
when events overlap. The bug can easily be reproduced by creating the
same events.
We are using Horde Groupware Webmail Edtion 1.2.3 with 1.2.4 patch
Thanks for your help