6.0.0-beta1
7/7/25

[#8677] Explicit :text in sieve body rule
Summary Explicit :text in sieve body rule
Queue Ingo
Queue Version 1.2
Type Enhancement
State Rejected
Priority 1. Low
Owners
Requester brennan (at) columbia (dot) edu
Created 11/05/2009 (5723 days ago)
Due
Updated 11/07/2009 (5721 days ago)
Assigned
Resolved 11/07/2009 (5721 days ago)
Milestone
Patch No

History
11/07/2009 02:03:59 PM Jan Schneider Comment #2
State ⇒ Rejected
Reply to this comment
Since it works fine as it is, I rather don't want to potentially break 
some implementations. It's not meant for human consumption anyway.
11/05/2009 03:22:54 PM brennan (at) columbia (dot) edu Comment #1
State ⇒ New
Priority ⇒ 1. Low
Type ⇒ Enhancement
Summary ⇒ Explicit :text in sieve body rule
Queue ⇒ Ingo
Milestone ⇒
Patch ⇒ No
Reply to this comment
Should ingo/lib/Script/sieve.php put :text explicitly into body 
checks?  RFC 5173 says that body transform "can" be applied (odd 
word-- not may or should) and that :text is the default (or that is, 
it "can" be the default?).  Cyrus sieve does default to :text.  Still, 
adding :text would clarify to humans reading the script that only text 
parts will be searched.  One-line diff below.

Forget this if there are sieve implementations that don't do body 
transform at all that would break on being told :text.


--- 2125,2131 ----
       function toCode()
       {
           $code = 'body ' .
+           ':text ' .
               ':comparator "' . $this->_vars['comparator'] . '" ' .
               $this->_vars['match-type'] . '


Saved Queries