[#8638] ListAlarms: retrieve only calendars with events having alarm
Summary ListAlarms: retrieve only calendars with events having alarm
Queue Kronolith
Queue Version 2.3.2
Type Enhancement
State Resolved
Priority 1. Low
Owners Jan Schneider <jan (at) horde (dot) org>
Requester patrick (dot) abiven (at) apitech (dot) fr
Created 10/14/2009 (153 days ago)
Due
Updated 01/12/2010 (63 days ago)
Assigned
Resolved 10/14/2009 (153 days ago)
Attachments
Milestone 2.3.3
Patch No

History
01/12/2010 CVS Commit Comment #5 Reply to this comment
Changes have been made in Git for this ticket:

Speed up listing alarms (Request #8638).

http://git.horde.org/diff.php/kronolith/docs/CHANGES?rt=horde-git&r1=09797b5ba08875de7c6c81ac6339818122e1b80d&r2=b8c03895ec6fb150adbc3f5a2644cac3a6ffc202
http://git.horde.org/diff.php/kronolith/lib/Api.php?rt=horde-git&r1=cdd3a283320b87a5ea9aa0ea09a14371f46a9bf3&r2=b8c03895ec6fb150adbc3f5a2644cac3a6ffc202
10/14/2009 Jan Schneider Comment #4
Milestone ⇒ 2.3.3
State ⇒ Resolved
Assigned to Jan Schneider		 Reply to this comment
That's really a nice catch and an impressive improvement, thanks a lot!
10/14/2009 CVS Commit Comment #3 Reply to this comment
Changes have been made in CVS for this ticket:

MFH: Speed up listing alarms (Request #8638).
http://cvs.horde.org/diff.php/kronolith/docs/CHANGES?rt=horde&r1=1.165.2.272&r2=1.165.2.273&ty=u
http://cvs.horde.org/diff.php/kronolith/lib/api.php?rt=horde&r1=1.126.2.64&r2=1.126.2.65&ty=u
10/14/2009 CVS Commit Comment #2 Reply to this comment
Changes have been made in Git for this ticket:

Speed up listing alarms (Request #8638).

http://git.horde.org/diff.php/kronolith/docs/CHANGES?rt=horde-hatchery&r1=09797b5ba08875de7c6c81ac6339818122e1b80d&r2=b8c03895ec6fb150adbc3f5a2644cac3a6ffc202
http://git.horde.org/diff.php/kronolith/lib/Api.php?rt=horde-hatchery&r1=cdd3a283320b87a5ea9aa0ea09a14371f46a9bf3&r2=b8c03895ec6fb150adbc3f5a2644cac3a6ffc202
10/14/2009 patrick (dot) abiven (at) apitech (dot) fr Comment #1
State ⇒ New
Patch ⇒
Milestone ⇒
Queue ⇒ Kronolith
Summary ⇒ ListAlarms: retrieve only calendars with events having alarm
Type ⇒ Enhancement
Priority ⇒ 1. Low		 Reply to this comment
Hello

For reducing the duration of the Horde_Alarm reminder script, in 
kronolith/lib/Kronolith.php, listAlarms(): instead of storing all 
calendars, can we only store calendars in which exist events with 
alarm ?

In our case, that will improve performances for about 40 seconds.



function listAlarms

- $alarms[$cal] = $kronolith_driver->listAlarms($date, $fullevent);



+ $result = $kronolith_driver->listAlarms($date, $fullevent);

+ if (! empty($result) ) {

+   $alarms[$cal] = $result;

+ }