| Summary | vacation rule : maildrop/mailbot locks |
| Queue | Ingo |
| Queue Version | Git master |
| Type | Bug |
| State | Resolved |
| Priority | 2. Medium |
| Owners | jan (at) horde (dot) org |
| Requester | rsalmon (at) mbpgroup (dot) com |
| Created | 09/15/2009 (5793 days ago) |
| Due | |
| Updated | 01/13/2010 (5673 days ago) |
| Assigned | 09/15/2009 (5793 days ago) |
| Resolved | 09/15/2009 (5793 days ago) |
| Github Issue Link | |
| Github Pull Request | |
| Milestone | |
| Patch | Yes |
Use a lock name that's different from mailbot's seen database name
(
Bug #8577).http://git.horde.org/diff.php/ingo/lib/Script/Maildrop.php?rt=horde-git&r1=9b22223f642b6ab65a71694ff34f709f06dfce9d&r2=5a978e4ae04ac8ffa7b04046f91416d7aa347d01
MFH: Use a lock name that's different from mailbot's seen database
name (
Bug #8577).http://cvs.horde.org/diff.php/ingo/docs/CHANGES?rt=horde&r1=1.55.2.126&r2=1.55.2.127&ty=u
http://cvs.horde.org/diff.php/ingo/lib/Script/maildrop.php?rt=horde&r1=1.7.2.14&r2=1.7.2.15&ty=u
Assigned to Jan Schneider
State ⇒ Resolved
Use a lock name that's different from mailbot's seen database name
(
Bug #8577).http://git.horde.org/diff.php/ingo/lib/Script/Maildrop.php?rt=horde-hatchery&r1=9b22223f642b6ab65a71694ff34f709f06dfce9d&r2=5a978e4ae04ac8ffa7b04046f91416d7aa347d01
auto-responses are active, wouldn't it make more sense to rename the
vacation lock file instead? I don't follow the maildrop code
completely, but isn't the vacation.lock created by flock only when
processing the current message? That wouldn't break anything if
upgrading Ingo on an active system.
from loosing user's db history.
So I guess the path would be (or some other file name!) :
- $this->_action[] = ' flock "vacation.lock" {';
+ $this->_action[] = ' flock "vacationdrop.lock" {';
Priority ⇒ 2. Medium
State ⇒ Feedback
auto-responses are active, wouldn't it make more sense to rename the
vacation lock file instead? I don't follow the maildrop code
completely, but isn't the vacation.lock created by flock only when
processing the current message? That wouldn't break anything if
upgrading Ingo on an active system.
Priority ⇒ 3. High
Type ⇒ Bug
Summary ⇒ vacation rule : maildrop/mailbot locks
Queue ⇒ Ingo
Milestone ⇒
Patch ⇒ Yes
State ⇒ Unconfirmed
database file is defined with arg '-d '.
In file ingo/lib/Script/maildrop.php:523, database filename is defined
as 'vacation'. Therefore mailbot uses file 'vacation.lock' as the file
lock , which is the same file lock defined for maildrop (line 516).
so, if a user set start and end vacation dates, maildrop and mailbot
will try to lock the same file which will never work.
here is a patch:
- $this->_action[] = " cc \"| mailbot -D " .
$params['action-value']['days'] . " -c '" . NLS::getCharset() . "' -t
\$HOME/vacation.msg -d \$HOME/vacation -A 'From: $from' -s '" .
MIME::encode($params['action-value']['subject'], NLS::getCharset()) .
"' /usr/sbin/sendmail -t \"";
+ $this->_action[] = " cc \"| mailbot -D " .
$params['action-value']['days'] . " -c '" . NLS::getCharset() . "' -t
\$HOME/vacation.msg -d \$HOME/vacationbot -A 'From: $from' -s '" .
MIME::encode($params['action-value']['subject'], NLS::getCharset()) .
"' /usr/sbin/sendmail -t \"";