Summary | Sent mail folder does not auto-create |
Queue | IMP |
Queue Version | 4.3.4 |
Type | Bug |
State | Resolved |
Priority | 2. Medium |
Owners | slusarz (at) horde (dot) org |
Requester | bugs (at) skeena (dot) net |
Created | 08/22/2009 (5799 days ago) |
Due | |
Updated | 01/13/2010 (5655 days ago) |
Assigned | 08/23/2009 (5798 days ago) |
Resolved | 11/20/2009 (5709 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | Yes |
Bug #8520: Make sure sent mail folder exists if using drop-downselection on compose page
http://git.horde.org/diff.php/imp/compose.php?rt=horde-git&r1=b821d067b0e30206e6acfdaff8ac860a49754814&r2=dffa0a9f401f8b73c0e8a90f67b78f81c797a369
http://git.horde.org/diff.php/imp/docs/CHANGES?rt=horde-git&r1=4b2f4623ae225c6bb2fb0b514ba039e24d114098&r2=dffa0a9f401f8b73c0e8a90f67b78f81c797a369
http://git.horde.org/diff.php/imp/lib/Views/Compose.php?rt=horde-git&r1=caedb70f6047930a3e941a6263b97db7e3e0eac6&r2=dffa0a9f401f8b73c0e8a90f67b78f81c797a369
Assigned to Michael Slusarz
State ⇒ Resolved
folder selection is allowed.
Bug: 8520Merge from git:horde-hatchery dffa0a9f401f8b73c0e8a90f67b78f81c797a369
http://cvs.horde.org/diff.php/imp/compose.php?rt=horde&r1=2.800.2.126&r2=2.800.2.127&ty=u
http://cvs.horde.org/diff.php/imp/docs/CHANGES?rt=horde&r1=1.699.2.413&r2=1.699.2.414&ty=u
Bug #8520: Make sure sent mail folder exists if using drop-downselection on compose page
http://git.horde.org/diff.php/imp/compose.php?rt=horde-hatchery&r1=b821d067b0e30206e6acfdaff8ac860a49754814&r2=dffa0a9f401f8b73c0e8a90f67b78f81c797a369
http://git.horde.org/diff.php/imp/docs/CHANGES?rt=horde-hatchery&r1=4b2f4623ae225c6bb2fb0b514ba039e24d114098&r2=dffa0a9f401f8b73c0e8a90f67b78f81c797a369
http://git.horde.org/diff.php/imp/lib/Views/Compose.php?rt=horde-hatchery&r1=caedb70f6047930a3e941a6263b97db7e3e0eac6&r2=dffa0a9f401f8b73c0e8a90f67b78f81c797a369
anyway; I don't see the harm in doing it early. If the message is
composed but not sent and the user hits "save draft", it still goes
into the drafts folder and the new sent mail folder stays empty --
nothing wrong with that; pretty much all e-mail programs (and most
forms of webmail) have a sent mail folder as a permanent fixture; if
you never send anything it just stays empty.
message in the sent-mail folder, without auto-creating it won't even
be available in the drop-down list. I don't see the harm in
pre-creating the folder. If identified as the sent-mail folder in the
prefs, it is eventually going to be created anyway.
be created when starting message composition
composed-but-maybe-not-sent-mail folder.
I don't see the harm in doing it early. If the message is composed but
not sent and the user hits "save draft", it still goes into the drafts
folder and the new sent mail folder stays empty -- nothing wrong with
that; pretty much all e-mail programs (and most forms of webmail) have
a sent mail folder as a permanent fixture; if you never send anything
it just stays empty.
be created when starting message composition
composed-but-maybe-not-sent-mail folder.
be created when starting message composition
State ⇒ Feedback
be created when starting message composition, but only when sending
the message (or really when trying to save the sent message).
Patch ⇒ Yes
State ⇒ Unconfirmed
New Attachment: compose.php_sent-mail-autocreate
Milestone ⇒
Queue ⇒ IMP
Summary ⇒ Sent mail folder does not auto-create
Type ⇒ Bug
Priority ⇒ 2. Medium
are able to choose where to save each message from a drop-down in the
compose screen. If the default named sent-mail folder does not exist
for that user, the drop-down defaults to the first existing folder
(sorted case-sensitive alphabetically) -- often this is Drafts. IMP
does not attempt to create the default sent-mail folder, except in the
case where the Inbox is the *only* other existent folder.
If the sent mail folder setting is locked in prefs.php, users are not
offered the drop-down menu and the sent mail folder *is* auto-created
if it does not exist.
This is a regression of a much earlier bug; I found references to it
from 2002 or so via Google. It may have been fixed in an earlier
version of compose.php; see line 1001 in compose.php Revision
2.800.2.16 (http://cvs.horde.org/co.php/imp/compose.php?r=2.800.2.16):
if (!$imp_folder->exists($imp['stream'], $sent_mail_folder)) {
$imp_folder->create($imp['stream'], $sent_mail_folder,
$prefs->getValue('subscribe'));
}
My patch creates the sent-mail folder much earlier on, so that it's
ready by the time the drop-down appears.