Tickets :: [#8446] Login tasks running in wrong frame

6.0.0-beta1

10/18/25

Summary	Login tasks running in wrong frame
Queue	Horde Framework Packages
Queue Version	Git master
Type	Bug
State	Resolved
Priority	2. Medium
Owners	slusarz (at) horde (dot) org
Requester	jan (at) horde (dot) org
Created	07/22/2009 (5932 days ago)
Due
Updated	07/29/2009 (5925 days ago)
Assigned	07/29/2009 (5925 days ago)
Resolved	07/29/2009 (5925 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	No

07/29/2009 06:11:36 PM	Michael Slusarz	Comment #8 State ⇒ Resolved	Reply to this comment
I've converted all the api-ish scripts in services to skip logintasks. Also modified the logic so that if 'none' authentication is requested, logintasks aren't performed.

07/29/2009 05:51:37 PM	CVS Commit	Comment #7	Reply to this comment
Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/horde/lib/base.php?rt=horde&r1=1.64&r2=1.65&ty=u http://cvs.horde.org/diff.php/horde/services/cache.php?rt=horde&r1=1.2&r2=1.3&ty=u http://cvs.horde.org/diff.php/horde/services/cacheview.php?rt=horde&r1=1.17&r2=1.18&ty=u http://cvs.horde.org/diff.php/horde/services/changepassword.php?rt=horde&r1=1.13&r2=1.14&ty=u http://cvs.horde.org/diff.php/horde/services/confirm.php?rt=horde&r1=1.11&r2=1.12&ty=u http://cvs.horde.org/diff.php/horde/services/images/view.php?rt=horde&r1=1.33&r2=1.34&ty=u http://cvs.horde.org/diff.php/horde/services/imple.php?rt=horde&r1=1.6&r2=1.7&ty=u http://cvs.horde.org/diff.php/horde/services/keyboard.php?rt=horde&r1=1.24&r2=1.25&ty=u http://cvs.horde.org/diff.php/horde/services/portal/cloud_search.php?rt=horde&r1=1.5&r2=1.6&ty=u http://cvs.horde.org/diff.php/horde/services/portal/sidebar.php?rt=horde&r1=1.46&r2=1.47&ty=u http://cvs.horde.org/diff.php/horde/services/snooze.php?rt=horde&r1=1.8&r2=1.9&ty=u http://cvs.horde.org/diff.php/horde/services/twitterapi.php?rt=horde&r1=1.4&r2=1.5&ty=u

07/29/2009 05:36:43 PM	Jan Schneider	Comment #6 State ⇒ Assigned	Reply to this comment
True, though we should add the variable there anyway, just to be safe. You never know, a session times out, a user leaves the browser open over night, or sets a bookmark on some weird page etc.

07/29/2009 05:36:04 PM	Michael Slusarz	State ⇒ Feedback

07/29/2009 05:33:51 PM	Michael Slusarz	Comment #5	Reply to this comment
I agree that completing that task would render be kind of a fix. But we still have to make sure to not run the login tasks from any other screens that are not supposed to run them, like popup windows etc. Good point. Turns out I already had a base.php variable handling this - $horde_login_page - so I changed the name to $horde_no_logintasks and added this variable to the sidebar script. Other pages that shouldn't run logintasks will need to be added as we find them. I'm going to assume that many/most of the scripts in services/ shouldn't run logintasks, but outside of directly accessing these scripts they will never be run without first going through horde code.

07/29/2009 05:29:43 PM	CVS Commit	Comment #4	Reply to this comment
Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/horde/lib/base.php?rt=horde&r1=1.63&r2=1.64&ty=u http://cvs.horde.org/diff.php/horde/login.php?rt=horde&r1=2.225&r2=2.226&ty=u http://cvs.horde.org/diff.php/horde/services/logintasks.php?rt=horde&r1=1.10&r2=1.11&ty=u http://cvs.horde.org/diff.php/horde/services/portal/sidebar.php?rt=horde&r1=1.45&r2=1.46&ty=u

07/29/2009 05:00:21 PM	Jan Schneider	Comment #3	Reply to this comment
I agree that completing that task would render be kind of a fix. But we still have to make sure to not run the login tasks from any other screens that are not supposed to run them, like popup windows etc.

07/28/2009 11:11:42 PM	Michael Slusarz	Comment #2	Reply to this comment
Before trying to track this down, I'd rather see movement on ~~Bug #8421~~ instead.

07/22/2009 08:55:50 AM	Jan Schneider	Comment #1 State ⇒ Assigned Patch ⇒ No Milestone ⇒ Assigned to Michael Slusarz Queue ⇒ Horde Framework Packages Summary ⇒ Login tasks running in wrong frame Type ⇒ Bug Priority ⇒ 2. Medium	Reply to this comment
The login tasks are currently running in the frame that's first loaded in the frameset, so they might run in the menu frame.