Summary | malformed img tag causes images to be shown regardless of html_image_replacement setting |
Queue | IMP |
Queue Version | 4.3.4 |
Type | Bug |
State | Resolved |
Priority | 1. Low |
Owners | slusarz (at) horde (dot) org |
Requester | mrubinsk (at) horde (dot) org |
Created | 07/06/2009 (5846 days ago) |
Due | |
Updated | 01/13/2010 (5655 days ago) |
Assigned | |
Resolved | 07/07/2009 (5845 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | No |
Bug #8413: Fix regex to capture some malformed img tagshttp://git.horde.org/diff.php/imp/lib/Mime/Viewer/Html.php?rt=horde-git&r1=eb76b66a06e626568552dc22adb3103f53e596bd&r2=9fcdba88dd23b8980d634b5d39d4af9499041235
Assigned to Michael Slusarz
State ⇒ Resolved
attribute. The regex was too greedy and was ignoring all text in the
tag between '<img' and the final 'src=' text. Solution was to make
that part of the regex ungreedy.
An img tag with multiple src attributes that doesn't contain a correct
source link in the first src attribute will not display the image at
all, even after clicking on Display these images. But absent a
super-complex preg regex, this is acceptable (after all, the message
is broken).
Running tidy fixed this issue without the need for the regexp change.
http://cvs.horde.org/diff.php/imp/lib/MIME/Viewer/html.php?rt=horde&r1=1.75.2.39&r2=1.75.2.40&ty=u
New Attachment: Teste (Imagem Google).eml
browser-specific.
nothing is displayed. In IMP 4.3.5, I get the option to unblock
images, but nothing is displayed by default.
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ malformed img tag causes images to be shown regardless of html_image_replacement setting
Queue ⇒ IMP
Milestone ⇒
Patch ⇒ No
State ⇒ Unconfirmed
following will still render the image:
<img src=http://www.google.pt/intl/en_com/images/logo_plain.png
onload=`" src=`>