6.0.0-beta1
7/8/25

[#8413] malformed img tag causes images to be shown regardless of html_image_replacement setting
Summary malformed img tag causes images to be shown regardless of html_image_replacement setting
Queue IMP
Queue Version 4.3.4
Type Bug
State Resolved
Priority 1. Low
Owners slusarz (at) horde (dot) org
Requester mrubinsk (at) horde (dot) org
Created 07/06/2009 (5846 days ago)
Due
Updated 01/13/2010 (5655 days ago)
Assigned
Resolved 07/07/2009 (5845 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
07/07/2009 10:17:10 PM Michael Slusarz Comment #6
Assigned to Michael Slusarz
State ⇒ Resolved
Reply to this comment
That img tag had 2 src attributes, and had the info in the first 
attribute.  The regex was too greedy and was ignoring all text in the 
tag between '<img' and the final 'src=' text.  Solution was to make 
that part of the regex ungreedy.



An img tag with multiple src attributes that doesn't contain a correct 
source link in the first src attribute will not display the image at 
all, even after clicking on Display these images.  But absent a 
super-complex preg regex, this is acceptable (after all, the message 
is broken).



Running tidy fixed this issue without the need for the regexp change.
07/06/2009 07:04:02 PM Chuck Hagenbuch Comment #4
New Attachment: Teste (Imagem Google).eml Download
Reply to this comment
adding an example message
07/06/2009 06:27:25 PM Chuck Hagenbuch Comment #3 Reply to this comment
The image shows up for me. Using Safari - not sure if this might be 
browser-specific.
07/06/2009 05:43:57 PM Michael Slusarz Comment #2 Reply to this comment
I can't reproduce this, with either IMP 5 or IMP 4.3.5.  In IMP 5, 
nothing is displayed.  In IMP 4.3.5, I get the option to unblock 
images, but nothing is displayed by default.
07/06/2009 03:15:47 PM Michael Rubinsky Comment #1
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ malformed img tag causes images to be shown regardless of html_image_replacement setting
Queue ⇒ IMP
Milestone ⇒
Patch ⇒ No
State ⇒ Unconfirmed
Reply to this comment
Choosing to block images in HTML mail, and receiving an email with the 
following will still render the image:

<img src=http://www.google.pt/intl/en_com/images/logo_plain.png 
onload=`" src=`>

Saved Queries