Tickets :: [#8315] VFS_smb.php Directory Listing broken

6.0.0-beta1

7/20/25

Summary	VFS_smb.php Directory Listing broken
Queue	Horde Framework Packages
Queue Version	Git master
Type	Bug
State	Resolved
Priority	2. Medium
Owners	jan (at) horde (dot) org
Requester	herde (at) tu-harburg (dot) de
Created	05/29/2009 (5896 days ago)
Due	06/10/2009 (5884 days ago)
Updated	05/31/2010 (5529 days ago)
Assigned	05/29/2009 (5896 days ago)
Resolved	05/10/2010 (5550 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	No

05/31/2010 08:56:28 AM	herde (at) tu-harburg (dot) de	Comment #6 New Attachment: smb.diff	Reply to this comment
Not really, because large parts of the smb driver have been rewritten since H3. this (see diff) seems to work in our case. any side effects to worry about from your point of view ?

05/28/2010 01:02:29 PM	Jan Schneider	Comment #5	Reply to this comment
Not really, because large parts of the smb driver have been rewritten since H3.

05/28/2010 12:42:26 PM	herde (at) tu-harburg (dot) de	Comment #4	Reply to this comment
This has been fixed in Git. Thank you for working on this bug - would it be possible to 'backport' this solution to this version ... H4 is very far away from becoming a release canditate, isn't it ?

05/10/2010 12:40:20 PM	Jan Schneider	Comment #3 Version ⇒ Git master State ⇒ Resolved Assigned to Jan Schneider	Reply to this comment
This has been fixed in Git.

05/31/2009 05:36:08 PM	CVS Commit	Comment #2	Reply to this comment
Changes have been made in CVS for this ticket: http://cvs.horde.org/co.php/framework/VFS/test/VFS/SmbTest.php?rt=horde&r=1.1 http://cvs.horde.org/co.php/framework/VFS/test/VFS/fixtures/samba1.txt?rt=horde&r=1.1 http://cvs.horde.org/co.php/framework/VFS/test/VFS/fixtures/samba2.txt?rt=horde&r=1.1

05/29/2009 02:50:19 PM	Chuck Hagenbuch	Queue ⇒ Horde Framework Packages Version ⇒ HEAD State ⇒ Assigned

05/29/2009 02:41:32 PM	herde (at) tu-harburg (dot) de	Comment #1 Priority ⇒ 2. Medium Type ⇒ Bug Summary ⇒ VFS_smb.php Directory Listing broken Due ⇒ 06/10/2009 Queue ⇒ Gollem Milestone ⇒ Patch ⇒ No New Attachment: test.txt State ⇒ Unconfirmed	Reply to this comment
Horde 3.3.4 with Gollem H3 (1.1) on RHEL 5.3 (SAMBA 3.0.33-3.7.el5) - we found out that VFS_smb.php (v 1.1.2.2) line 385 ff of function listFolder() // Split into columns at every six spaces $split1 = preg_split('/\s{6,}/', trim($res[$r])); // If the file name isn't . or .. turns out a broken directory listing if there is a long filename in conjunction with more than one Attribute setted (i.e. DA) because there are less than 6 expected spaces between the name of the item and the attribute list. the attribute list is more the one entry in this case. Only if we hafe 6 or more spaces in between here the regex will match correctly. Example output of manualy listing of smbclient - see attached txt-file. turns out this strange broken directory listing "SystemHiddenReadonlyArchive DAHSR" 0 Wed May 27 14:17:21 2009 as to see in the attached screenshot https://webmail.tu-harburg.de/horde/imp/attachment.php?u=rztmh&t=1243596710&f=brokendirectorylistinggollem.bmp The regex should match the attribute column [DHARS] in an appropriate way. freundliche Grüsse Michael Herde