Summary | After a bad login a successful mobile login takes the user to DIMP as opposed to MIMP |
Queue | MIMP |
Queue Version | 1.1.1 |
Type | Bug |
State | Resolved |
Priority | 2. Medium |
Owners | |
Requester | rorymckinley (at) gmail (dot) com |
Created | 05/27/2009 (5882 days ago) |
Due | |
Updated | 03/13/2011 (5227 days ago) |
Assigned | 06/04/2009 (5874 days ago) |
Resolved | 03/13/2011 (5227 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | No |
State ⇒ Resolved
Taken from Michael Slusarz
State ⇒ Stalled
been rewritten in H4.
Assigned to
State ⇒ Assigned
Priority ⇒ 2. Medium
This problem persists - we were initially using a custom
redirect_on_logout but we removed that. Now, this problem occurs every
time we logout, not even on badlogins :(
bad login ? Would it be possible to do this via a config setting?
to my mail site, I get sent to a mobile friendly Horde login page. An
incorrect login drops me back to that page, upon which a correct login
sends me to MIMP. I.e. I can't reproduce this. Maybe because I am not
using Imp for auth but passing back to Horde?
help me patch the file (I am guessing redirect.php) - I am willing to
try it and test - if that will help things along.
State ⇒ Unconfirmed
Patch ⇒ No
Milestone ⇒
Queue ⇒ MIMP
Summary ⇒ After a bad login a successful mobile login takes the user to DIMP as opposed to MIMP
Type ⇒ Bug
Priority ⇒ 3. High
of imp/login.php. If I incorrectly enter the wrong password, I am
rerouted back to the mobile version of login.php. If I get my password
correct this time, I get routed to the DIMP interface as opposed to
the MIMP interface.
The cause for this behaviour lies in imp/redirect.php:
When I first hit the login page - my login url is
blah.com/imp/login.php?url=%2Findex.php. When I submit my details,
imp/redirect.php looks for a value of $GLOBALS['url_in'] (passed by
the login page) in the _newSessionUrl function. If $GLOBALS['url_in']
is set, then the url to which I am redirected is defined by $url =
Horde::url(Util::removeParameter($GLOBALS['url_in'], session_name()),
true). This works.
However, if I put in a bad password, I get redirected to a url that
looks something like this...
blah.com/imp/login.php?imapuser=webmaster%40blah.com&horde_logout_token=lTaSVF7eQJ-qNlFXmp8B6lEyxfo&app=imp&logout_reason=badlogin.
If I log in now, redirect.php cannot find a value for
GLOBALS['url_in'] - and _newSessionUrl calls this line of code:
return Horde::url($GLOBALS['registry']->get('webroot', $view) . '/',
true); (line 295)
As a result I am routed to DIMP. It currently looks as if the problem
is caused by the fact that the GLOBALS['url_in'] variable is not set
after a good login from the login page after a bad login. This is
currently only a problem for mobile logins.
I do not know enough about the code base to determine if the problem
lies with redirect.php or the way that the login page is populated
after a bad login.