Are you really still using FRAMEWORK_3 of Rdo? That code was only a 
showcase for upcoming features, the latest is in Git.

After poking around with this a bit more, I've realized that This only 
happens for MySQL tables that have not set their primary key field to 
auto_increment.  I'm still not convinced it's best form to dump an 
empty primary key down an insert statement, but MySQL does handle this 
gracefully when the table is an auto_increment table. I have not 
tested this on other database server types. Here is example SQL 
generated by Horde_Rdo_Adapter::create.



INSERT INTO `mytable` (`mytable_id`, `user_uid`, `title`, 
`description`, `created`, `updated`) VALUES (?, ?, ?, ?, ?, ?)



Values Array ( [0] => [1] => admin [2] => actually [3] => do it [4] => 
1240893214 [5] => 1240893214 )

No also. Forgot to erase it. Thank you.

PROBLEM



The Horde_Rdo_Mapper::update tries to create new records from 
Horde_Rdo_Base objects, assigning a null value for the primary key.



Example:



class MyTable extends Horde_Rdo_Base ...



$row = new MyTable(array(some values here));

$row->save();  // calls the mapper update function



Fatal error: Uncaught exception 'Horde_Rdo_Exception' with message 
'Column 'mytable_id' cannot be null...



This is happening with a fairly default Apache/PHP installation on a 
MacBook using MySQL.



PATCH



Suggest modifying the Horde_Rdo_Mapper::update function to unset the 
primary key before calling create on the array. The key has already 
been proven empty by the if statement, so I can't imagine any negative 
effect here.



     public function update($object, $fields = null)

     {

         if ($object instanceof Horde_Rdo_Base) {

             $key = $this->model->key;

             $id = $object->$key;

             $fields = iterator_to_array($object);



             if (!$id) {

                 // Object doesn't exist yet; create it instead.

                 unset($fields[$key]);

                 $object = $this->create($fields);

                 return 1;

             }



SIDENOTE



The CVS repository for Rdo seems to be missing or just not showing files:



http://cvs.horde.org/framework/Rdo/Rdo/



Also,