6.0.0-beta1
7/7/25

[#8185] Subject double-escaped in the message view
Summary Subject double-escaped in the message view
Queue IMP
Queue Version Git master
Type Bug
State Resolved
Priority 1. Low
Owners Horde Developers (at) , slusarz (at) horde (dot) org
Requester chuck (at) horde (dot) org
Created 04/13/2009 (5929 days ago)
Due
Updated 01/13/2010 (5654 days ago)
Assigned 04/15/2009 (5927 days ago)
Resolved 05/19/2009 (5893 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
01/13/2010 12:02:37 AM CVS Commit Comment #8 Reply to this comment
Changes have been made in Git for this ticket:

Ticket #8185: Revert "Don't show subject in page header."
This reverts commit ed1e359c809354bee6175215a63a10402ae22c68.
Truncate subject text in header also.

http://git.horde.org/diff.php/imp/message.php?rt=horde-git&r1=a253d734b1b1fc2b8b9376ddddeb5fdb7fd86e7e&r2=35ad9c6b347a412d110a8eac57564b7be9f94e6e
05/19/2009 03:01:00 PM Michael Slusarz Comment #6
State ⇒ Resolved
Reply to this comment
I have no problem with having the subject
fragment in the header and then the full one later, but then imo we
should truncate the one in the header (which I used to do, and
someone reverted).
I can live with this.  Reverted initial commit and re-added truncation 
in header (at 100 chars).
04/17/2009 04:41:56 AM Chuck Hagenbuch Comment #5 Reply to this comment
But subject display in the header looks awful.  And for long
subjects, it is *very* difficult to read (and you can't truncate -
there needs to be at least one place where the full subject is
viewable).  The better solution is to highlight/move the Subject
header display - not to display the subject in the header.
Think about preview in the list page. Having even a fragment of the 
subject (which will often be the whole subject anyway) in the header 
is really important imo. I have no problem with having the subject 
fragment in the header and then the full one later, but then imo we 
should truncate the one in the header (which I used to do, and someone 
reverted).
04/16/2009 08:05:56 PM Michael Slusarz Comment #4 Reply to this comment
Disagree - the subject line is relevant for scanning and now it's
much harder to pick up at a glance. If that means dropping links from
the subject I think it's more than a fair trade (yes, I asked for
that one also I know).
But subject display in the header looks awful.  And for long subjects, 
it is *very* difficult to read (and you can't truncate - there needs 
to be at least one place where the full subject is viewable).  The 
better solution is to highlight/move the Subject header display - not 
to display the subject in the header.
04/15/2009 10:04:09 AM Chuck Hagenbuch Comment #3
State ⇒ Feedback
Reply to this comment
Disagree - the subject line is relevant for scanning and now it's much 
harder to pick up at a glance. If that means dropping links from the 
subject I think it's more than a fair trade (yes, I asked for that one 
also I know).
04/15/2009 05:42:00 AM Michael Slusarz Comment #2
State ⇒ Resolved
Reply to this comment
Fixed (this was due to the URL linking code added several weeks ago).



Also, it makes more sense to remove the duplicate subject info in the 
header - now that we link URLs in the subject, it makes more sense to 
display this with the other headers anyway.  I've removed this 
duplicate subject info in both IMP and the pop-up DIMP display.
04/13/2009 09:41:39 PM Chuck Hagenbuch Comment #1
Priority ⇒ 1. Low
State ⇒ Assigned
Patch ⇒ No
Milestone ⇒
Assigned to Horde DevelopersHorde Developers
Assigned to Michael Slusarz
Queue ⇒ IMP
Summary ⇒ Subject double-escaped in the message view
Type ⇒ Bug
Reply to this comment
In the message view, the subject header is double-escaped (not the one 
used in the header, but the one below To: ). So instead of seeing:



Re: New Message -> Attachment Button / Firefox 3



I see:



Re: New Message -> Attachment Button / Firefox 3





Given that this duplicates the header we might just remove it, too?

Saved Queries