Tickets :: [#8075] Add check for the PHP HASH moduly

6.0.0-RC7

6/18/26

History
Attachments
Comment
Watch
Download

Summary	Add check for the PHP HASH moduly
Queue	Horde Base
Queue Version	HEAD
Type	Enhancement
State	Resolved
Priority	1. Low
Owners	jan (at) horde (dot) org
Requester	wrobel (at) horde (dot) org
Created	3/12/09 (6307 days ago)
Due
Updated	6/16/09 (6211 days ago)
Assigned
Resolved	3/13/09 (6306 days ago)
Milestone
Patch	No

61	Jan Schneider	Comment #12	Reply to this comment
I got the problem on an OpenPKG system. The same system also lacked JSON support. So we should check for that one, too. After activating HASH and JSON Horde was running fine. JSON is a different story, because we have a fallback PHP implementation.

269	Gunnar Wrobel	Comment #11	Reply to this comment
I got the problem on an OpenPKG system. The same system also lacked JSON support. So we should check for that one, too. After activating HASH and JSON Horde was running fine. I also don't think we can influence the distros decisions there. In fact if you look at Gentoo it is not even a decision the package manager makes. On Gentoo the user has full control over all PHP modules by activating/deactiving the corresponding USE flags.

154	Jan Schneider	Comment #10	Reply to this comment
I have added --disable-hash to the error message. We already check for PCRE.

464	CVS Commit	Comment #9	Reply to this comment
Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/horde/test.php?rt=horde&r1=1.178&r2=1.179&ty=u

354	Michael Slusarz	Comment #8	Reply to this comment
Why? The list of extensions being enabled by default in PHP is changing all the time, so why not require the extension and make this clear on the test.php page? if that's the case, then there should also be mention that PHP should not be compiled with '--disable-hash' since that will also disable the hash module. And if we are going to check these kind of things, there are other modules we have to check as well. For example, as of PHP 5.2.x it is possible to disable PCRE functions.

582	Jan Schneider	Comment #7	Reply to this comment
Why? The list of extensions being enabled by default in PHP is changing all the time, so why not require the extension and make this clear on the test.php page? And I don't think it's our job to tell the distro maintainers which extensions to enables. And please note that even though I have seen this happening, I just assumed it was the distro's default, I didn't digg any further.

241	Chuck Hagenbuch	Comment #6	Reply to this comment
Arg. Can we detect these people and send email to the distro pointing out how utterly horrible this is?

2010	Jan Schneider	Comment #5 Assigned to Jan Schneider State ⇒ Resolved	Reply to this comment
This happened to me on a client's site too, I guess there are a few people, or even worse, several distributions, that might use --disable-all. So I tweaked the error messages and committed it.

1510	CVS Commit	Comment #4	Reply to this comment
Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/horde/test.php?rt=horde&r1=1.176&r2=1.177&ty=u

39	Gunnar Wrobel	Comment #3	Reply to this comment
The problem occured on a php-5.2.8 installation on standard Kolab server. The installation uses configure with "--disable-all" though. Guess that might have caused the problem. Thanks for the feedback!

502	Chuck Hagenbuch	Comment #2 State ⇒ Rejected	Reply to this comment
hash is part of PHP core after 5.1.2; Horde HEAD requires 5.2+

596	Gunnar Wrobel	Comment #1 Patch ⇒ No State ⇒ New New Attachment: test_php.patch Milestone ⇒ Queue ⇒ Horde Base Summary ⇒ Add check for the PHP HASH moduly Type ⇒ Enhancement Priority ⇒ 1. Low	Reply to this comment
Horde_Secret within git HEAD requires the hash() function. The availabilty of this module should be checked in the test script as the login screen won't show otherwise. Patch attached.