6.0.0-beta1
7/20/25

[#7988] Fix creation of Horde_SessionObjects in Horde_Group
Summary Fix creation of Horde_SessionObjects in Horde_Group
Queue Horde Framework Packages
Queue Version Git master
Type Bug
State Resolved
Priority 1. Low
Owners mrubinsk (at) horde (dot) org
Requester duck (at) obala (dot) net
Created 02/15/2009 (5999 days ago)
Due
Updated 02/15/2009 (5999 days ago)
Assigned 02/15/2009 (5999 days ago)
Resolved 02/15/2009 (5999 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch Yes

History
02/15/2009 05:10:49 PM Michael Rubinsky Comment #4
Assigned to Michael Rubinsky
Summary ⇒ Fix creation of Horde_SessionObjects in Horde_Group
State ⇒ Resolved
Reply to this comment
Done.
02/15/2009 04:32:00 PM Duck Comment #3 Reply to this comment
The __construct method is protected because you should be using the
singleton method to create these objects.
Then you should update other libraries as Group, where SessionObjects 
is directly created (see functions singleton and shutdown) and you get:



( ! ) Fatal error: Call to protected 
Horde_SessionObjects::__construct() from context 'Group' in 
/usr/share/php5/Horde/Group.php on line 682

Call Stack

#       Time    Memory  Function        Location

1       0,0014  85068   {main}( )       ../view.php:0

2       0,2281  2952388 Ansel_View_List->html( )        ../view.php:52

3       0,2288  2954888 Ansel_Storage->countGalleries( )         
../List.php:172

4       0,2288  2955820 Horde_Share_sql_hierarchical->countShares( )   
  ../Ansel.php:3698

5       0,2288  2956180 
Horde_Share_sql_hierarchical->_getShareCriteria( )       
../sql_hierarchical.php:580

6       0,2323  3104292 Group->singleton( )     ../sql_hierarchical.php:221
02/15/2009 02:10:08 PM Michael Rubinsky Comment #2
State ⇒ Feedback
Reply to this comment
The __construct method is protected because you should be using the 
singleton method to create these objects.



Also, I seem to remember a comment/discussion about sticking with md5 
now since in newer PHP versions it is an alias to hash's md5 
implementation?
02/15/2009 10:13:13 AM Duck Comment #1
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ Fix __construct method
Queue ⇒ Horde Framework Packages
Milestone ⇒
Patch ⇒ Yes
New Attachment: SssionObjects.diff Download
State ⇒ Unconfirmed
Reply to this comment
- __construct must be public not protected

- replace md5 with hash

Saved Queries