6.0.0-alpha14
7/2/25

[#7974] API extension
Summary API extension
Queue Ansel
Queue Version HEAD
Type Enhancement
State Resolved
Priority 1. Low
Owners mrubinsk (at) horde (dot) org
Requester duck (at) obala (dot) net
Created 02/12/2009 (5984 days ago)
Due
Updated 03/02/2009 (5966 days ago)
Assigned 02/12/2009 (5984 days ago)
Resolved 03/02/2009 (5966 days ago)
Milestone
Patch Yes

History
03/02/2009 11:28:54 PM Michael Rubinsky Comment #9
State ⇒ Resolved
Reply to this comment
Committed.  I changed the age/locked gallery detection so that it 
catches these even if it's a full image download. I don't see 
permission to download a full image as implicit permission to see an 
otherwise locked gallery.
03/02/2009 11:27:48 PM CVS Commit Comment #8 Reply to this comment
02/17/2009 10:30:19 AM Duck Comment #7
New Attachment: api[2].diff Download
Reply to this comment
That might be one of the reasons that I can't get any image data from
a webdav mount of a remote ansel install...
I corrected _getImageData to be bidirectional and updated PHPDoc.
02/16/2009 06:42:35 PM Michael Rubinsky Comment #6 Reply to this comment
I doubt anyone will request image raw data directly or we can encode
it if you prefer.
IMO, if it's callable via the api, it's callable via jsonrpc and 
xmlrpc so it should be supported and this won't work unless it is 
encoded.
But we need a way to make it accessible via the API
to have a full read-write api.
I've been making http requests for the image data whenever I've needed 
to do this - I do this in my iPhoto plugin for example, to get the the 
gallery default images, but I can see the usefulness of having this 
method as well.  I think we should be able to specify the encoding we 
want when requesting the image - the reverse of how the upload works, 
where we need to specify the encoding that we are using during upload.
OTOH even the browse call sends raw
data directly.
That might be one of the reasons that I can't get any image data from 
a webdav mount of a remote ansel install...




02/16/2009 03:59:12 PM Duck Comment #5
New Attachment: ansel.php Download
Reply to this comment
An example of full RW implementation as a VFS driver.
02/16/2009 03:55:40 PM Duck Comment #4
New Attachment: api[1].diff Download
Reply to this comment
1) The return datatype in the signature for getImageContent is incorrect

2) All parameters with default values in a function signature must
follow all parameters that do not have a default value.

3) Your not checking age restrictions or password protected galleries
before returning the image data.
Fixed...
That being said, I'm not so sure this api method is a good idea -
will sening the raw, binary image data actually work over XML/RPC or
JSON/RPC?
I doubt anyone will request image raw data directly or we can encode 
it if you prefer. But we need a way to make it accessible via the API 
to have a full read-write api. OTOH even the browse call sends raw 
data directly.


02/12/2009 03:51:08 PM Michael Rubinsky Comment #3
State ⇒ Feedback
Reply to this comment
1) The return datatype in the signature for getImageContent is incorrect



2) All parameters with default values in a function signature must 
follow all parameters that do not have a default value.



3) Your not checking age restrictions or password protected galleries 
before returning the image data.



That being said, I'm not so sure this api method is a good idea - will 
sening the raw, binary image data actually work over XML/RPC or 
JSON/RPC?
02/12/2009 03:12:15 PM Chuck Hagenbuch Assigned to Michael Rubinsky
State ⇒ Assigned
 
02/12/2009 10:54:36 AM Duck Comment #2 Reply to this comment
- fix fatal error in removeGallery when getGallery returns and error 
and we try to access an non defined method in the error message 
composition


02/12/2009 10:52:35 AM Duck Comment #1
Priority ⇒ 1. Low
State ⇒ New
New Attachment: api.diff Download
Patch ⇒ Yes
Milestone ⇒
Queue ⇒ Ansel
Summary ⇒ API extension
Type ⇒ Enhancement
Reply to this comment
- fix galleryExists signature

- fix warnings in saveImage regarding type of image content passed

- added method to return image view raw data

Saved Queries